net/quic/reliable_quic_stream.h - Issue 1261273003: relnote: Change the QuicStreamSequencer to call OnDataAvailable instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/reliable_quic_stream.h

Issue 1261273003: relnote: Change the QuicStreamSequencer to call OnDataAvailable instead (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace DonReading with OnFinRead Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/reliable_quic_stream.h

diff --git a/net/quic/reliable_quic_stream.h b/net/quic/reliable_quic_stream.h

index 6e70a1d1a7dbccdd5a0f83844b3b903208873c67..7cc26c86d4987369ddacbbdf57db7ab1097360cd 100644

--- a/net/quic/reliable_quic_stream.h

+++ b/net/quic/reliable_quic_stream.h

@@ -73,9 +73,9 @@ class NET_EXPORT_PRIVATE ReliableQuicStream {

// close, and should immediately close the stream.

virtual void OnConnectionClosed(QuicErrorCode error, bool from_peer);

- // Called by the sequencer after ProcessRawData has accepted the final

- // incoming data.

- virtual void OnFinRead();

+ // Called by the stream subclass after it has consumed the final incoming

+ // data.

+ void OnFinRead();

// Called when new data is available from the sequencer. Subclasses must

// actively retrieve the data using the sequencer's Readv() or

« no previous file with comments | « net/quic/quic_stream_sequencer_test.cc ('k') | net/tools/quic/quic_spdy_server_stream.h » ('j') | no next file with comments »