Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1261033002: Rename GrInOrderDrawBuffer to GrBufferedDrawTarget (Closed)

Created:
5 years, 4 months ago by joshua.litt
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rename GrInOrderDrawBuffer to GrBufferedDrawTarget BUG=skia: Committed: https://skia.googlesource.com/skia/+/b542bae1f5a2726e52a15fa90acec7e7b935cb71

Patch Set 1 #

Total comments: 2

Patch Set 2 : iodb #

Patch Set 3 : renames #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -429 lines) Patch
M gyp/gpu.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleManyRects.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + src/gpu/GrBufferedDrawTarget.h View 1 2 1 chunk +10 lines, -14 lines 0 comments Download
A + src/gpu/GrBufferedDrawTarget.cpp View 10 chunks +39 lines, -39 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrCommandBuilder.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 4 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrInOrderCommandBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrInOrderCommandBuilder.cpp View 1 3 chunks +6 lines, -5 lines 0 comments Download
D src/gpu/GrInOrderDrawBuffer.h View 1 chunk +0 lines, -147 lines 0 comments Download
D src/gpu/GrInOrderDrawBuffer.cpp View 1 chunk +0 lines, -201 lines 0 comments Download
M src/gpu/GrReorderCommandBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTargetCommands.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrTargetCommands.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrTracing.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
joshualitt
5 years, 4 months ago (2015-07-28 16:07:10 UTC) #3
robertphillips
lgtm https://codereview.chromium.org/1261033002/diff/1/src/gpu/GrBufferedDrawTarget.h File src/gpu/GrBufferedDrawTarget.h (right): https://codereview.chromium.org/1261033002/diff/1/src/gpu/GrBufferedDrawTarget.h#newcode15 src/gpu/GrBufferedDrawTarget.h:15: /** Fix refs in comments too. https://codereview.chromium.org/1261033002/diff/1/src/gpu/GrTest.cpp File ...
5 years, 4 months ago (2015-07-28 16:12:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261033002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261033002/40001
5 years, 4 months ago (2015-07-28 16:51:24 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 16:58:41 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/b542bae1f5a2726e52a15fa90acec7e7b935cb71

Powered by Google App Engine
This is Rietveld 408576698