Gray horizontal keyboard accessory

ui/android/java/res/layout/autofill_keyboard_accessory_item.xml

Index: ui/android/java/res/layout/autofill_keyboard_accessory_item.xml
diff --git a/ui/android/java/res/layout/autofill_keyboard_accessory_item.xml b/ui/android/java/res/layout/autofill_keyboard_accessory_item.xml
new file mode 100644
index 0000000000000000000000000000000000000000..c1faa951df98927b369c9cb463a4cfddd69ad066
--- /dev/null
+++ b/ui/android/java/res/layout/autofill_keyboard_accessory_item.xml
@@ -0,0 +1,61 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2015 The Chromium Authors. All rights reserved.
+     Use of this source code is governed by a BSD-style license that can be
+     found in the LICENSE file. -->
+
+<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
+        xmlns:tools="http://schemas.android.com/tools"
+        android:layout_height="48dp"
+        android:layout_width="wrap_content"
+        android:orientation="vertical"
+        android:paddingBottom="@dimen/keyboard_accessory_padding"
+        android:paddingEnd="@dimen/keyboard_accessory_half_padding"
+        android:paddingStart="@dimen/keyboard_accessory_half_padding"
+        android:paddingTop="@dimen/keyboard_accessory_padding">
+
+    <LinearLayout

[aurimas (slooooooooow), 2015/07/29 00:16:08]

We can remove FrameLayout and keep just LinearLayout by using InsetDrawable [1]
to draw the background that is slightly smaller than the view.

[1]
http://developer.android.com/reference/android/graphics/drawable/InsetDrawabl...

[please use gerrit instead, 2015/07/30 21:04:23]

Done.

+            android:background="@drawable/autofill_chip"
+            android:layout_height="@dimen/keyboard_accessory_chip_height"
+            android:layout_width="wrap_content"
+            android:paddingEnd="@dimen/keyboard_accessory_half_padding"
+            android:paddingStart="@dimen/keyboard_accessory_half_padding">
+
+        <ImageView android:id="@+id/autofill_keyboard_accessory_item_icon"
+                android:gravity="center_vertical|center_horizontal"
+                android:layout_height="match_parent"
+                android:layout_width="wrap_content"
+                android:minWidth="@dimen/keyboard_accessory_chip_height"
+                android:visibility="gone"
+                tools:ignore="ContentDescription" />
+
+        <TextView android:id="@+id/autofill_keyboard_accessory_item_name"
+                android:requiresFadingEdge="horizontal"
+                android:fadingEdgeLength="@dimen/keyboard_accessory_fading_edge_length"
+                android:ellipsize="none"

[aurimas (slooooooooow), 2015/07/29 00:16:08]

I think this might be the default value. Can you try removing this and make sure
it still works?

[please use gerrit instead, 2015/07/30 21:04:23]

Removing this results in "..." at the end of the TextView. So, ellipsize="end"
is the default.

+                android:fontFamily="sans-serif-medium"
+                android:gravity="center_vertical|start"

[aurimas (slooooooooow), 2015/07/29 00:16:08]

Do we need the gravity to be start? We set width to wrap_content so the text
will already be the same width as the TextView. Same with the text below.

[please use gerrit instead, 2015/07/30 21:04:23]

Removed "start" and everything still looks correct.

+                android:layout_height="match_parent"
+                android:layout_width="wrap_content"
+                android:paddingEnd="@dimen/keyboard_accessory_half_padding"
+                android:paddingStart="@dimen/keyboard_accessory_half_padding"
+                android:singleLine="true"
+                android:textColor="#333"

[aurimas (slooooooooow), 2015/07/29 00:16:08]

you can use @color/default_text_color

[please use gerrit instead, 2015/07/30 21:04:23]

default_text_color is in chrome/, which is not available in chrome/. (Weird that
we have this separation. I thought "chrome" essentially means user interface
that is not the webpage.)

+                android:textSize="@dimen/keyboard_accessory_text_size"

[aurimas (slooooooooow), 2015/07/29 00:16:08]

What happens when you set your device font to extra large in Android settings?

[please use gerrit instead, 2015/07/30 21:04:23]

This text size increases as well, because I am using "sp" units.

+                android:visibility="gone" />
+
+        <TextView android:id="@+id/autofill_keyboard_accessory_item_label"
+                android:requiresFadingEdge="horizontal"
+                android:fadingEdgeLength="@dimen/keyboard_accessory_fading_edge_length"
+                android:ellipsize="none"
+                android:gravity="center_vertical|start"
+                android:layout_height="match_parent"
+                android:layout_width="wrap_content"
+                android:paddingEnd="@dimen/keyboard_accessory_half_padding"
+                android:singleLine="true"
+                android:textColor="#646464"
+                android:textSize="@dimen/keyboard_accessory_text_size"
+                android:visibility="gone" />
+
+    </LinearLayout>
+
+</FrameLayout>