ui/android/java/res/layout/autofill_keyboard_accessory_item.xml - Issue 1260583004: Gray horizontal keyboard accessory

Side by Side Diff: ui/android/java/res/layout/autofill_keyboard_accessory_item.xml

Issue 1260583004: Gray horizontal keyboard accessory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Horizontal padding and font colors. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java ('K') | « ui/android/java/res/drawable/autofill_chip.xml ('k') | ui/android/java/res/values/colors.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"

	7 xmlns:tools="http://schemas.android.com/tools"

	8 android:layout_height="48dp"

	9 android:layout_width="wrap_content"

	10 android:orientation="vertical"

	11 android:paddingBottom="@dimen/keyboard_accessory_padding"

	12 android:paddingEnd="@dimen/keyboard_accessory_half_padding"

	13 android:paddingStart="@dimen/keyboard_accessory_half_padding"

	14 android:paddingTop="@dimen/keyboard_accessory_padding">

	15

	16 <LinearLayout
	aurimas (slooooooooow) 2015/07/29 00:16:08 We can remove FrameLayout and keep just LinearLayo We can remove FrameLayout and keep just LinearLayout by using InsetDrawable [1] to draw the background that is slightly smaller than the view. [1] http://developer.android.com/reference/android/graphics/drawable/InsetDrawabl... please use gerrit instead 2015/07/30 21:04:23 Done. Show quoted text On 2015/07/29 00:16:08, aurimas wrote: > We can remove FrameLayout and keep just LinearLayout by using InsetDrawable [1] > to draw the background that is slightly smaller than the view. > > [1] > http://developer.android.com/reference/android/graphics/drawable/InsetDrawabl... Done.
	17 android:background="@drawable/autofill_chip"

	18 android:layout_height="@dimen/keyboard_accessory_chip_height"

	19 android:layout_width="wrap_content"

	20 android:paddingEnd="@dimen/keyboard_accessory_half_padding"

	21 android:paddingStart="@dimen/keyboard_accessory_half_padding">

	22

	23 <ImageView android:id="@+id/autofill_keyboard_accessory_item_icon"

	24 android:gravity="center_vertical\|center_horizontal"

	25 android:layout_height="match_parent"

	26 android:layout_width="wrap_content"

	27 android:minWidth="@dimen/keyboard_accessory_chip_height"

	28 android:visibility="gone"

	29 tools:ignore="ContentDescription" />

	30

	31 <TextView android:id="@+id/autofill_keyboard_accessory_item_name"

	32 android:requiresFadingEdge="horizontal"

	33 android:fadingEdgeLength="@dimen/keyboard_accessory_fading_edge_ length"

	34 android:ellipsize="none"
	aurimas (slooooooooow) 2015/07/29 00:16:08 I think this might be the default value. Can you t I think this might be the default value. Can you try removing this and make sure it still works? please use gerrit instead 2015/07/30 21:04:23 Removing this results in "..." at the end of the T Show quoted text On 2015/07/29 00:16:08, aurimas wrote: > I think this might be the default value. Can you try removing this and make sure > it still works? Removing this results in "..." at the end of the TextView. So, ellipsize="end" is the default.
	35 android:fontFamily="sans-serif-medium"

	36 android:gravity="center_vertical\|start"
	aurimas (slooooooooow) 2015/07/29 00:16:08 Do we need the gravity to be start? We set width t Do we need the gravity to be start? We set width to wrap_content so the text will already be the same width as the TextView. Same with the text below. please use gerrit instead 2015/07/30 21:04:23 Removed "start" and everything still looks correct Show quoted text On 2015/07/29 00:16:08, aurimas (OOO until Aug 17) wrote: > Do we need the gravity to be start? We set width to wrap_content so the text > will already be the same width as the TextView. Same with the text below. Removed "start" and everything still looks correct.
	37 android:layout_height="match_parent"

	38 android:layout_width="wrap_content"

	39 android:paddingEnd="@dimen/keyboard_accessory_half_padding"

	40 android:paddingStart="@dimen/keyboard_accessory_half_padding"

	41 android:singleLine="true"

	42 android:textColor="#333"
	aurimas (slooooooooow) 2015/07/29 00:16:08 you can use @color/default_text_color you can use @color/default_text_color please use gerrit instead 2015/07/30 21:04:23 default_text_color is in chrome/, which is not ava Show quoted text On 2015/07/29 00:16:08, aurimas wrote: > you can use @color/default_text_color default_text_color is in chrome/, which is not available in chrome/. (Weird that we have this separation. I thought "chrome" essentially means user interface that is not the webpage.)
	43 android:textSize="@dimen/keyboard_accessory_text_size"
	aurimas (slooooooooow) 2015/07/29 00:16:08 What happens when you set your device font to extr What happens when you set your device font to extra large in Android settings? please use gerrit instead 2015/07/30 21:04:23 This text size increases as well, because I am usi Show quoted text On 2015/07/29 00:16:08, aurimas wrote: > What happens when you set your device font to extra large in Android settings? This text size increases as well, because I am using "sp" units.
	44 android:visibility="gone" />

	45

	46 <TextView android:id="@+id/autofill_keyboard_accessory_item_label"

	47 android:requiresFadingEdge="horizontal"

	48 android:fadingEdgeLength="@dimen/keyboard_accessory_fading_edge_ length"

	49 android:ellipsize="none"

	50 android:gravity="center_vertical\|start"

	51 android:layout_height="match_parent"

	52 android:layout_width="wrap_content"

	53 android:paddingEnd="@dimen/keyboard_accessory_half_padding"

	54 android:singleLine="true"

	55 android:textColor="#646464"

	56 android:textSize="@dimen/keyboard_accessory_text_size"

	57 android:visibility="gone" />

	58

	59 </LinearLayout>

	60

	61 </FrameLayout>

OLD	NEW