Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3070)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java

Issue 1260583004: Gray horizontal keyboard accessory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Horizontal padding and font colors. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java
index e1ff2644ca9b42461c0a9f4c0da1d9e9f10787a1..f94d924192710550077ae30156b8ee7043054d1e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java
@@ -98,15 +98,17 @@ public class AutofillKeyboardAccessoryBridge implements AutofillKeyboardAccessor
/**
* @param array AutofillSuggestion array that should get a new suggestion added.
* @param index Index in the array where to place a new suggestion.
- * @param label First line of the suggestion.
+ * @param name Suggested text. Usually the text that's going to be filled in the focused field.
aurimas (slooooooooow) 2015/07/29 00:16:08 "Usually"? What else could it be?
please use gerrit instead 2015/07/30 21:04:23 It could be "Visa ****-3333", which indicates that
+ * @param label Hint for the suggested text. Usually what's going to be filled in the rest of
+ * the form.
* @param iconId The resource ID for the icon associated with the suggestion, or 0 for no icon.
* @param suggestionId Identifier for the suggestion type.
*/
@CalledByNative
private static void addToAutofillSuggestionArray(AutofillSuggestion[] array, int index,
- String label, int iconId, int suggestionId) {
+ String name, String label, int iconId, int suggestionId) {
int drawableId = iconId == 0 ? DropdownItem.NO_ICON : ResourceId.mapToDrawableId(iconId);
- array[index] = new AutofillSuggestion(label, null, drawableId, suggestionId, false);
+ array[index] = new AutofillSuggestion(name, label, drawableId, suggestionId, false);
}
private native void nativeViewDismissed(long nativeAutofillKeyboardAccessoryView);

Powered by Google App Engine
This is Rietveld 408576698