Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Side by Side Diff: Source/core/css/MediaValuesDynamic.h

Issue 1260403002: Oilpan: Remove raw pointer to LocalFrame from MediaValuesDynamic (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MediaValuesDynamic_h 5 #ifndef MediaValuesDynamic_h
6 #define MediaValuesDynamic_h 6 #define MediaValuesDynamic_h
7 7
8 #include "core/css/MediaValues.h" 8 #include "core/css/MediaValues.h"
9 9
10 namespace blink { 10 namespace blink {
(...skipping 25 matching lines...) Expand all
36 const String mediaType() const override; 36 const String mediaType() const override;
37 WebDisplayMode displayMode() const override; 37 WebDisplayMode displayMode() const override;
38 Document* document() const override; 38 Document* document() const override;
39 bool hasValues() const override; 39 bool hasValues() const override;
40 40
41 protected: 41 protected:
42 MediaValuesDynamic(LocalFrame*); 42 MediaValuesDynamic(LocalFrame*);
43 43
44 // This raw ptr is safe, as MediaValues would not outlive MediaQueryEvaluato r, and 44 // This raw ptr is safe, as MediaValues would not outlive MediaQueryEvaluato r, and
45 // MediaQueryEvaluator is reset on |Document::detach|. 45 // MediaQueryEvaluator is reset on |Document::detach|.
46 // FIXME: Oilpan: This raw ptr should be changed to a Member when LocalFrame is migrated to the heap. 46 RawPtrWillBePersistent<LocalFrame> m_frame;
haraken 2015/07/30 06:08:58 If the RawPtrWillBePersistent doesn't cause a cycl
keishi 2015/08/06 06:48:49 Done.
47 LocalFrame* m_frame;
48 }; 47 };
49 48
50 } // namespace 49 } // namespace
51 50
52 #endif // MediaValuesDynamic_h 51 #endif // MediaValuesDynamic_h
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698