Oilpan: Remove raw pointer to LocalFrame from MediaValuesDynamic

Source/core/css/MediaValuesCached.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/css/MediaValuesCached.h"
 
 #include "core/css/CSSPrimitiveValue.h"
 #include "core/dom/Document.h"
 #include "core/frame/LocalFrame.h"
 #include "core/layout/LayoutObject.h"
 
 namespace blink {
 
-PassRefPtr<MediaValues> MediaValuesCached::create()
+PassRefPtrWillBeRawPtr<MediaValues> MediaValuesCached::create()
 {
-    return adoptRef(new MediaValuesCached());
+    return adoptRefWillBeNoop(new MediaValuesCached());
 }
 
-PassRefPtr<MediaValues> MediaValuesCached::create(MediaValuesCachedData& data)
+PassRefPtrWillBeRawPtr<MediaValues> MediaValuesCached::create(MediaValuesCachedData& data)
 {
-    return adoptRef(new MediaValuesCached(data));
+    return adoptRefWillBeNoop(new MediaValuesCached(data));
 }
 
-PassRefPtr<MediaValues> MediaValuesCached::create(Document& document)
+PassRefPtrWillBeRawPtr<MediaValues> MediaValuesCached::create(Document& document)
 {
     return MediaValuesCached::create(frameFrom(document));
 }
 
-PassRefPtr<MediaValues> MediaValuesCached::create(LocalFrame* frame)
+PassRefPtrWillBeRawPtr<MediaValues> MediaValuesCached::create(LocalFrame* frame)
 {
     // FIXME - Added an assert here so we can better understand when a frame is present without its view().
     ASSERT(!frame || frame->view());
     if (!frame || !frame->view())
-        return adoptRef(new MediaValuesCached());
+        return adoptRefWillBeNoop(new MediaValuesCached());
     ASSERT(frame->document() && frame->document()->layoutView());
-    return adoptRef(new MediaValuesCached(frame));
+    return adoptRefWillBeNoop(new MediaValuesCached(frame));
 }
 
 MediaValuesCached::MediaValuesCached()
 {
 }
 
 MediaValuesCached::MediaValuesCached(LocalFrame* frame)
 {
     ASSERT(isMainThread());
     ASSERT(frame);
@@ skipping 17 matching lines @@
     const String mediaType = calculateMediaType(frame);
     if (!mediaType.isEmpty())
         m_data.mediaType = mediaType.isolatedCopy();
 }
 
 MediaValuesCached::MediaValuesCached(const MediaValuesCachedData& data)
     : m_data(data)
 {
 }
 
-PassRefPtr<MediaValues> MediaValuesCached::copy() const
+PassRefPtrWillBeRawPtr<MediaValues> MediaValuesCached::copy() const
 {
-    return adoptRef(new MediaValuesCached(m_data));
+    return adoptRefWillBeNoop(new MediaValuesCached(m_data));
 }
 
 bool MediaValuesCached::computeLength(double value, CSSPrimitiveValue::UnitType type, int& result) const
 {
     return MediaValues::computeLength(value, type, m_data.defaultFontSize, m_data.viewportWidth, m_data.viewportHeight, result);
 }
 
 bool MediaValuesCached::computeLength(double value, CSSPrimitiveValue::UnitType type, double& result) const
 {
     return MediaValues::computeLength(value, type, m_data.defaultFontSize, m_data.viewportWidth, m_data.viewportHeight, result);
 }
 
 bool MediaValuesCached::isSafeToSendToAnotherThread() const
 {
+#if ENABLE(OILPAN)
+    return true;

[haraken, 2015/08/06 08:54:34]

Worth having a comment on why it is always safe to pass the MediaValues to
another thread in oilpan.

[keishi, 2015/08/10 06:50:46]

Done. Could you take a look and see if this is correct?

    // Oilpan objects are safe to send to another thread as long as the thread
    // does not outlive the thread used for creation. MediaValues are
    // allocated on the main thread and may be passed to the parser thread,
    // so this should be safe.

+#else
     return hasOneRef();
+#endif
 }
 
 int MediaValuesCached::viewportWidth() const
 {
     return m_data.viewportWidth;
 }
 
 int MediaValuesCached::viewportHeight() const
 {
     return m_data.viewportHeight;
@@ skipping 78 matching lines @@
 {
     m_data.viewportWidth = width;
 }
 
 void MediaValuesCached::setViewportHeight(int height)
 {
     m_data.viewportHeight = height;
 }
 
 } // namespace