Move ShouldFilterAutofillResult from ChromePasswordManagerClient to PasswordManager

components/password_manager/core/browser/store_result_filter.h

Index: components/password_manager/core/browser/store_result_filter.h
diff --git a/components/password_manager/core/browser/store_result_filter.h b/components/password_manager/core/browser/store_result_filter.h
new file mode 100644
index 0000000000000000000000000000000000000000..5c7d26e1cffba5e05dd05c1ee7c81be54d624fc1
--- /dev/null
+++ b/components/password_manager/core/browser/store_result_filter.h
@@ -0,0 +1,28 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_STORE_RESULT_FILTER_H_
+#define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_STORE_RESULT_FILTER_H_
+
+#include "components/autofill/core/common/password_form.h"

[engedy, 2015/08/04 10:11:29]

nit: I don't feel strongly about this, and know that forward-declarations are a
contentious topic, just wanted to make sure this is intentionally including and
not forward-declaring.

[vabr (Chromium), 2015/08/04 12:21:25]

Thanks for checking. This was deliberate:

The public Google C++ guide linked from Chromium style [1] says: "The practical
efficiency benefits of forward declarations are unproven." While it also allows
forward declarations, it does not suggest using them, and the internal C++ guide
is against forward declarations.

I'm aware that most of Chromium code, even password manager code, uses forward
declarations. I might even have introduced forward declarations in this CL, out
of old habit. This is not ideal, but I also do not see it as a big problem so
far. If you feel strongly about consistency, let's file a bug to get rid of
forward declarations in password manager, and do a sweep to fix this.

[1]
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Forward_Decla...

[engedy, 2015/08/04 13:06:35]

As I said, I don't feel strongly about this. Just wanted to double-check if you
do. :)

+
+namespace password_manager {
+
+// This interface is used by PasswordFormManager to filter results from the
+// PasswordStore.
+class StoreResultFilter {
+ public:
+  StoreResultFilter() {}
+  virtual ~StoreResultFilter() {}
+
+  // Should |form| be ignored for any password manager-related purposes?
+  virtual bool ShouldIgnore(const autofill::PasswordForm& form) = 0;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(StoreResultFilter);
+};
+
+}  // namespace password_manager
+
+#endif  // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_STORE_RESULT_FILTER_H_