Move ShouldFilterAutofillResult from ChromePasswordManagerClient to PasswordManager

components/password_manager/core/browser/stub_password_manager_client.cc

Index: components/password_manager/core/browser/stub_password_manager_client.cc
diff --git a/components/password_manager/core/browser/stub_password_manager_client.cc b/components/password_manager/core/browser/stub_password_manager_client.cc
index ec7410b8c0a7544003b1dbdf3a418092d0f5744f..1931cccaab0595175206fab9f5902f102eb7a14a 100644
--- a/components/password_manager/core/browser/stub_password_manager_client.cc
+++ b/components/password_manager/core/browser/stub_password_manager_client.cc
@@ -4,11 +4,25 @@
 
 #include "components/password_manager/core/browser/stub_password_manager_client.h"
 
+#include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "components/password_manager/core/browser/password_form_manager.h"
+#include "components/password_manager/core/browser/store_result_filter.h"
 
 namespace password_manager {
 
+namespace {
+
+// This filter does not filter out anything, it is a dummy implementation of
+// the filter interface.
+class DisabledStoreResultFilter : public StoreResultFilter {

[engedy, 2015/08/04 10:11:29]

nit: s/Disabled/PassThrough/g

[vabr (Chromium), 2015/08/04 12:21:25]

Done.

+ public:
+  bool ShouldIgnore(const autofill::PasswordForm& form) override {
+    return false;
+  }
+};
+}
+
 StubPasswordManagerClient::StubPasswordManagerClient() {
 }
 
@@ -25,11 +39,6 @@ bool StubPasswordManagerClient::IsSyncAccountCredential(
   return false;
 }
 
-bool StubPasswordManagerClient::ShouldFilterAutofillResult(
-    const autofill::PasswordForm& form) {
-  return false;
-}
-
 bool StubPasswordManagerClient::PromptUserToSavePassword(
     scoped_ptr<PasswordFormManager> form_to_save,
     password_manager::CredentialSourceType type) {
@@ -60,4 +69,13 @@ PasswordStore* StubPasswordManagerClient::GetPasswordStore() const {
   return nullptr;
 }
 
+const GURL& StubPasswordManagerClient::GetLastCommittedEntryURL() const {
+  return GURL::EmptyGURL();
+}
+
+scoped_ptr<StoreResultFilter>
+StubPasswordManagerClient::CreateStoreResultFilter() const {
+  return make_scoped_ptr(new DisabledStoreResultFilter);
+}
+
 }  // namespace password_manager