Move ShouldFilterAutofillResult from ChromePasswordManagerClient to PasswordManager

components/password_manager/core/browser/password_manager_client.h

Index: components/password_manager/core/browser/password_manager_client.h
diff --git a/components/password_manager/core/browser/password_manager_client.h b/components/password_manager/core/browser/password_manager_client.h
index a8f28920b2105e880da0a92d2e9b0e83127e4289..609d0243eba6a6406865cc63bb6816731c68a468 100644
--- a/components/password_manager/core/browser/password_manager_client.h
+++ b/components/password_manager/core/browser/password_manager_client.h
@@ -9,6 +9,7 @@
 #include "base/memory/scoped_vector.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/password_manager/core/browser/password_store.h"
+#include "components/password_manager/sync/browser/sync_store_result_filter.h"

[engedy, 2015/08/04 10:11:29]

Shouldn't this be core/browser/store_result_filter.h?

[vabr (Chromium), 2015/08/04 12:21:25]

Indeed. And had I done the DEPS right, presubmit would have caught that. Fixed
now.

 
 class PrefService;
 
@@ -59,10 +60,6 @@ class PasswordManagerClient {
   // of SSL errors on a page.
   virtual bool IsSavingEnabledForCurrentPage() const;
 
-  // Return true if |form| should not be available for autofill.
-  virtual bool ShouldFilterAutofillResult(
-      const autofill::PasswordForm& form) = 0;
-
   // Return the username that the user is syncing with. Should return an empty
   // string if sync is not enabled for passwords.
   virtual std::string GetSyncUsername() const = 0;
@@ -72,10 +69,6 @@ class PasswordManagerClient {
   virtual bool IsSyncAccountCredential(const std::string& username,
                                        const std::string& realm) const = 0;
 
-  // Called when all autofill results have been computed. Client can use
-  // this signal to report statistics. Default implementation is a noop.
-  virtual void AutofillResultsComputed();
-
   // Informs the embedder of a password form that can be saved if the user
   // allows it. The embedder is not required to prompt the user if it decides
   // that this form doesn't need to be saved.
@@ -171,6 +164,13 @@ class PasswordManagerClient {
   // Returns the main frame URL.
   virtual const GURL& GetMainFrameURL() const;
 
+  virtual const GURL& GetLastCommittedEntryURL() const = 0;
+
+  // Creates a single-use filter for PasswordFormManager to process password

[engedy, 2015/08/04 10:11:29]

We should update this comment to better describe the lifetime requirements.

[vabr (Chromium), 2015/08/04 12:21:25]

Done. Please check if it is any better now.

[engedy, 2015/08/04 13:06:35]

SGTM, thanks!

+  // store response.
+  virtual scoped_ptr<password_manager::StoreResultFilter>
+  CreateStoreResultFilter() const = 0;
+
  private:
   DISALLOW_COPY_AND_ASSIGN(PasswordManagerClient);
 };