gpu: Add calling convention for win32

gpu: Add calling convention for win32

I'm in the process of making a command buffer gles2 dll that can be consumed
by skia.  Skia, on windows 32, uses __stdcall for it's gl functions, so to
expose the gl interface to skia, we need to be using the same calling
convention.

Angle and GL both use __stdcall on win32.

Committed: https://crrev.com/0f8de4a5c189bf0bde032657d3d715bae46def2f
Cr-Commit-Position: refs/heads/master@{#341953}

[hendrikw, 2015-07-28 18:20:46]

hendrikw@chromium.org changed reviewers:
+ vmiura@chromium.org, zmo@chromium.org

[hendrikw, 2015-07-28 18:20:46]

PTAL.

I'm not too sure about the change I had to make to the khronos header.  It looks
like we removed the calling convention from the original header, so I think it's
ok to remove that code??

[hendrikw, 2015-07-28 18:21:49]

hendrikw@chromium.org changed reviewers:
+ kbr@chromium.org

[hendrikw, 2015-07-28 18:22:50]

hendrikw@chromium.org changed reviewers:
+ piman@chromium.org

[hendrikw, 2015-07-28 18:23:21]

On 2015/07/28 18:20:46, hendrikw wrote:
> PTAL.
> 
> I'm not too sure about the change I had to make to the khronos header.  It
looks
> like we removed the calling convention from the original header, so I think
it's
> ok to remove that code??

Added kbr for KHR, and piman for egl/egl.cc

[piman, 2015-07-28 18:43:16]

lgtm

https://codereview.chromium.org/1260253003/diff/1/gpu/gles2_conform_support/e...
File gpu/gles2_conform_support/egl/egl.cc (right):

https://codereview.chromium.org/1260253003/diff/1/gpu/gles2_conform_support/e...
gpu/gles2_conform_support/egl/egl.cc:402: return
(__eglMustCastToProperFunctionPointerType)gles2::GetGLFunctionPointer(
nit: no c-style cast, use a static_cast (if possible) or reinterpret_cast.

[hendrikw, 2015-07-28 18:48:19]

On 2015/07/28 18:43:16, piman (Very slow to review) wrote:
> lgtm
> 
>
https://codereview.chromium.org/1260253003/diff/1/gpu/gles2_conform_support/e...
> File gpu/gles2_conform_support/egl/egl.cc (right):
> 
>
https://codereview.chromium.org/1260253003/diff/1/gpu/gles2_conform_support/e...
> gpu/gles2_conform_support/egl/egl.cc:402: return
> (__eglMustCastToProperFunctionPointerType)gles2::GetGLFunctionPointer(
> nit: no c-style cast, use a static_cast (if possible) or reinterpret_cast.

Oh yeah, done

[hendrikw, 2015-07-28 19:24:58]

On 2015/07/28 18:48:19, hendrikw wrote:
> On 2015/07/28 18:43:16, piman (Very slow to review) wrote:
> > lgtm
> > 
> >
>
https://codereview.chromium.org/1260253003/diff/1/gpu/gles2_conform_support/e...
> > File gpu/gles2_conform_support/egl/egl.cc (right):
> > 
> >
>
https://codereview.chromium.org/1260253003/diff/1/gpu/gles2_conform_support/e...
> > gpu/gles2_conform_support/egl/egl.cc:402: return
> > (__eglMustCastToProperFunctionPointerType)gles2::GetGLFunctionPointer(
> > nit: no c-style cast, use a static_cast (if possible) or reinterpret_cast.
> 
> Oh yeah, done

Hmm, I did this change for skia, and skia ends up failing my trybots.  Will look
into it.

[hendrikw, 2015-07-29 00:24:59]

hendrikw@chromium.org changed reviewers:
+ bsalomon@google.com

[hendrikw, 2015-07-29 00:26:19]

On 2015/07/28 19:24:58, hendrikw wrote:
> On 2015/07/28 18:48:19, hendrikw wrote:
> > On 2015/07/28 18:43:16, piman (Very slow to review) wrote:
> > > lgtm
> > > 
> > >
> >
>
https://codereview.chromium.org/1260253003/diff/1/gpu/gles2_conform_support/e...
> > > File gpu/gles2_conform_support/egl/egl.cc (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1260253003/diff/1/gpu/gles2_conform_support/e...
> > > gpu/gles2_conform_support/egl/egl.cc:402: return
> > > (__eglMustCastToProperFunctionPointerType)gles2::GetGLFunctionPointer(
> > > nit: no c-style cast, use a static_cast (if possible) or reinterpret_cast.
> > 
> > Oh yeah, done
> 
> Hmm, I did this change for skia, and skia ends up failing my trybots.  Will
look
> into it.

We weren't using __stdcall for skia.dll.

PTAL.

[piman, 2015-07-29 00:43:00]

lgtm

[hendrikw, 2015-07-30 20:07:39]

hendrikw@chromium.org changed reviewers:
+ jam@chromium.org

[hendrikw, 2015-07-30 20:07:40]

Added GL_APIENTRY to mojo as well.

+jam for mojo stuff.

[jam, 2015-07-30 20:21:22]

jam@chromium.org changed reviewers:
+ rockot@chromium.org

[jam, 2015-07-30 20:21:59]

On 2015/07/30 20:07:40, hendrikw wrote:
> Added GL_APIENTRY to mojo as well.
> 
> +jam for mojo stuff.

+rockot since he's doing rolls (last i know :) )

the code in third_party is from mojo repo, so it would have to be made there and
rolled. otherwise these changes would be lost on next roll.

[Ken Rockot(use gerrit already), 2015-07-30 20:30:57]

rockot@chromium.org changed reviewers:
+ jamesr@chromium.org

[Ken Rockot(use gerrit already), 2015-07-30 20:30:58]

Not sure who rolls chromium into mojo but I think this change will need to be
made upstream after the next such roll. +jamesr

[hendrikw, 2015-07-31 21:40:01]

On 2015/07/30 20:30:58, Ken Rockot wrote:
> Not sure who rolls chromium into mojo but I think this change will need to be
> made upstream after the next such roll. +jamesr

mojo changes here:

https://codereview.chromium.org/1258693003

Since making changes to chrome won't land without the mojo changes, and making
the mojo changes will break chrome without these changes, should I keep the mojo
changes here as well? (which will be overridden when we roll mojo, assuming
those changes land)

[Ken Rockot(use gerrit already), 2015-07-31 21:41:52]

Yes, it's fine to keep them in this CL as well

On Fri, Jul 31, 2015 at 2:40 PM, <hendrikw@chromium.org> wrote:

> On 2015/07/30 20:30:58, Ken Rockot wrote:
>
>> Not sure who rolls chromium into mojo but I think this change will need
>> to be
>> made upstream after the next such roll. +jamesr
>>
>
> mojo changes here:
>
> https://codereview.chromium.org/1258693003
>
> Since making changes to chrome won't land without the mojo changes, and
> making
> the mojo changes will break chrome without these changes, should I keep
> the mojo
> changes here as well? (which will be overridden when we roll mojo, assuming
> those changes land)
>
>
>
> https://codereview.chromium.org/1260253003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[hendrikw, 2015-07-31 22:30:54]

On 2015/07/31 21:41:52, Ken Rockot wrote:
> Yes, it's fine to keep them in this CL as well
> 
> On Fri, Jul 31, 2015 at 2:40 PM, <mailto:hendrikw@chromium.org> wrote:
> 
> > On 2015/07/30 20:30:58, Ken Rockot wrote:
> >
> >> Not sure who rolls chromium into mojo but I think this change will need
> >> to be
> >> made upstream after the next such roll. +jamesr
> >>
> >
> > mojo changes here:
> >
> > https://codereview.chromium.org/1258693003
> >
> > Since making changes to chrome won't land without the mojo changes, and
> > making
> > the mojo changes will break chrome without these changes, should I keep
> > the mojo
> > changes here as well? (which will be overridden when we roll mojo, assuming
> > those changes land)
> >
> >
> >
> > https://codereview.chromium.org/1260253003/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Cool, how about some more lgtms?

mojo:    @rockot|jam|jamesr
skia:    @bsalomon
khronos: @kbr

Thanks everyone!

[Ken Rockot(use gerrit already), 2015-07-31 22:31:45]

woops, sorry. lgtm :)

[Ken Russell (switch to Gerrit), 2015-07-31 22:37:03]

third_party/khronos conditional LGTM

https://codereview.chromium.org/1260253003/diff/160001/third_party/khronos/KH...
File third_party/khronos/KHR/khrplatform.h (left):

https://codereview.chromium.org/1260253003/diff/160001/third_party/khronos/KH...
third_party/khronos/KHR/khrplatform.h:135: #define KHRONOS_APIENTRY
Please update README.chromium to document this change. I don't remember the
changes made in this file relative to upstream, but it sounds like others were
made. Thanks.

[hendrikw, 2015-07-31 22:50:26]

hendrikw@chromium.org changed reviewers:
+ sky@chromium.org

[hendrikw, 2015-07-31 22:50:27]

+sky for mojo/gles2/gles2_impl.cc

https://codereview.chromium.org/1260253003/diff/160001/third_party/khronos/KH...
File third_party/khronos/KHR/khrplatform.h (left):

https://codereview.chromium.org/1260253003/diff/160001/third_party/khronos/KH...
third_party/khronos/KHR/khrplatform.h:135: #define KHRONOS_APIENTRY
On 2015/07/31 22:37:03, Ken Russell wrote:
> Please update README.chromium to document this change. I don't remember the
> changes made in this file relative to upstream, but it sounds like others were
> made. Thanks.

Done.

[sky, 2015-08-03 15:02:01]

sky@chromium.org changed reviewers:
- sky@chromium.org

[sky, 2015-08-03 15:02:01]

sky->jam

[bsalomon, 2015-08-03 17:54:29]

On 2015/08/03 15:02:01, sky wrote:
> sky->jam

skia lgtm

[jam, 2015-08-03 21:19:21]

lgtm

[hendrikw, 2015-08-03 21:19:49]

The CQ bit was checked by hendrikw@chromium.org

[hendrikw, 2015-08-03 21:19:49]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org,
kbr@chromium.org, rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/1260253003/#ps180001
(title: "update README.chromium for khr")

[commit-bot: I haz the power, 2015-08-03 21:19:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1260253003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1260253003/180001

[commit-bot: I haz the power, 2015-08-03 21:22:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-03 21:22:26]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hendrikw, 2015-08-03 23:08:05]

The CQ bit was checked by hendrikw@chromium.org

[hendrikw, 2015-08-03 23:08:05]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
rockot@chromium.org, jam@chromium.org, piman@chromium.org, bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1260253003/#ps200001
(title: "another merge")

[commit-bot: I haz the power, 2015-08-03 23:08:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1260253003/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1260253003/200001

[commit-bot: I haz the power, 2015-08-04 01:55:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-04 01:55:33]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[hendrikw, 2015-08-04 03:59:46]

The CQ bit was checked by hendrikw@chromium.org

[hendrikw, 2015-08-04 03:59:52]

The CQ bit was unchecked by hendrikw@chromium.org

[commit-bot: I haz the power, 2015-08-04 03:59:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1260253003/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1260253003/200001

[hendrikw, 2015-08-05 16:40:18]

@zmo

hi, I saw an email going around about the bots being flaky, could this be the
reason I'm having trouble landing this?  

If I made a mistake, I would expect this cl to either cause a build break, or
straight up crash due to stack corruption, but I'm seeing failing tests.  That,
and I'm seeing x64 test failures, and __stdcall is ignored by the x64 compiler.

[hendrikw, 2015-08-05 16:40:33]

The CQ bit was checked by hendrikw@chromium.org

[commit-bot: I haz the power, 2015-08-05 16:41:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1260253003/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1260253003/200001

[commit-bot: I haz the power, 2015-08-05 17:44:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-05 17:44:46]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hendrikw, 2015-08-05 17:49:29]

On 2015/08/05 17:44:46, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

:/

FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc
"E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo
/showIncludes /FC @obj\third_party\libwebp\enc\libwebp_enc.cost.obj.rsp /c
..\..\third_party\libwebp\enc\cost.c
/Foobj\third_party\libwebp\enc\libwebp_enc.cost.obj
/Fdobj\third_party\libwebp\libwebp_enc.c.pdb 
GOMA:cl.exe ..\..\third_party\libwebp\enc\cost.c:*ERROR*: compiler_proxy:1232ms:
network error continued for a long time
FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc
"E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo
/showIncludes /FC
@obj\third_party\libwebp\enc\libwebp_enc.backward_references.obj.rsp /c
..\..\third_party\libwebp\enc\backward_references.c
/Foobj\third_party\libwebp\enc\libwebp_enc.backward_references.obj
/Fdobj\third_party\libwebp\libwebp_enc.c.pdb 
GOMA:cl.exe ..\..\third_party\libwebp\enc\backward_references.c:*ERROR*:
compiler_proxy:1638ms: network error continued for a long time
ninja: build stopped: subcommand failed.

trying again...

[hendrikw, 2015-08-05 17:49:39]

The CQ bit was checked by hendrikw@chromium.org

[commit-bot: I haz the power, 2015-08-05 17:51:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1260253003/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1260253003/200001

[commit-bot: I haz the power, 2015-08-05 20:17:13]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2015-08-05 20:17:54]

Patchset 11 (id:??) landed as
https://crrev.com/0f8de4a5c189bf0bde032657d3d715bae46def2f
Cr-Commit-Position: refs/heads/master@{#341953}