Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1258693003: mojo: add GL_APIENTRY (Closed)

Created:
5 years, 4 months ago by hendrikw
Modified:
5 years, 4 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

mojo: add GL_APIENTRY mojo changes to make everyone use the same calling convention on windows see: https://codereview.chromium.org/1260253003 R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d17aba5deb88a59cc9ada00c1f6d26e353778d06

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M mojo/gles2/gles2_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/platform/native/gles2_impl_chromium_copy_texture_thunks.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/platform/native/gles2_impl_chromium_copy_texture_thunks.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/platform/native/gles2_impl_chromium_image_thunks.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/platform/native/gles2_impl_chromium_image_thunks.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/platform/native/gles2_impl_chromium_miscellaneous_thunks.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/platform/native/gles2_impl_chromium_miscellaneous_thunks.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/platform/native/gles2_impl_chromium_pixel_transfer_buffer_object_thunks.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/platform/native/gles2_impl_chromium_pixel_transfer_buffer_object_thunks.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/platform/native/gles2_impl_chromium_resize_thunks.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/platform/native/gles2_impl_chromium_resize_thunks.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/platform/native/gles2_impl_chromium_sub_image_thunks.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/platform/native/gles2_impl_chromium_sub_image_thunks.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/platform/native/gles2_impl_chromium_sync_point_thunks.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/platform/native/gles2_impl_chromium_sync_point_thunks.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/platform/native/gles2_impl_chromium_texture_mailbox_thunks.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/platform/native/gles2_impl_chromium_texture_mailbox_thunks.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/platform/native/gles2_impl_occlusion_query_ext_thunks.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/platform/native/gles2_impl_occlusion_query_ext_thunks.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/platform/native/gles2_impl_thunks.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/platform/native/gles2_impl_thunks.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (1 generated)
hendrikw
PTAL, thanks!
5 years, 4 months ago (2015-07-31 22:31:35 UTC) #2
jamesr
lgtm
5 years, 4 months ago (2015-08-03 17:42:07 UTC) #3
jamesr
There's no CQ here, I can land this patch for you.
5 years, 4 months ago (2015-08-03 17:42:48 UTC) #4
hendrikw
On 2015/08/03 17:42:48, jamesr wrote: > There's no CQ here, I can land this patch ...
5 years, 4 months ago (2015-08-03 17:49:41 UTC) #5
jamesr
The mojo roll is decoupled, so this can land at any point relative to chrome ...
5 years, 4 months ago (2015-08-03 18:05:40 UTC) #6
hendrikw
On 2015/08/03 18:05:40, jamesr wrote: > The mojo roll is decoupled, so this can land ...
5 years, 4 months ago (2015-08-03 18:07:48 UTC) #7
hendrikw
On 2015/08/03 18:07:48, hendrikw wrote: > On 2015/08/03 18:05:40, jamesr wrote: > > The mojo ...
5 years, 4 months ago (2015-08-06 20:10:36 UTC) #8
jamesr
Committed patchset #1 (id:1) manually as d17aba5deb88a59cc9ada00c1f6d26e353778d06 (presubmit successful).
5 years, 4 months ago (2015-08-11 00:25:23 UTC) #9
jamesr
5 years, 4 months ago (2015-08-11 00:25:34 UTC) #10
Message was sent while issue was closed.
On 2015/08/06 at 20:10:36, hendrikw wrote:
> On 2015/08/03 18:07:48, hendrikw wrote:
> > On 2015/08/03 18:05:40, jamesr wrote:
> > > The mojo roll is decoupled, so this can land at any point relative to
chrome
> > > changes.  This patch landing won't impact chrome code until someone does
an
> > > explicit roll.
> > 
> > yeah, I realize that, I wanted to avoid the chance that someone rolls this
> > before I get the other cl in, but if you don't think that will happen,
please go
> > ahead and land, thanks!
> 
> Hi jamesr, the other cl has landed, please land this patch when you get a
chance, thanks!

Sorry for the delay, this is in now.

Powered by Google App Engine
This is Rietveld 408576698