Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1260163006: Detect missing inliner (Closed)

Created:
5 years, 4 months ago by Cutch
Modified:
5 years, 4 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Detect missing inliner 1) Apply this patch. 2) ./xcodebuild/DebugIA32/dart --trace_inlining_intervals DeltaBlue.dart 3) Inlined intervals: 0 id: 0 caller-id: -1 Inlined functions at: 0 0: Function 'List._fromLiteral@915557746': static factory. INLINER: Function 'List._fromLiteral@915557746': static factory. 6c id: 5 caller-id: 2 Inlined functions at: 6c 0: Function 'get:length':. !!! INLINER: Function 'List._fromLiteral@915557746': static factory. /Users/johnmccutchan/workspace/dart/sdk/runtime/vm/object.cc:13324: error: expected: function->raw() == inliner.raw() Abort trap: 6

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -12 lines) Patch
M runtime/vm/compiler.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 4 chunks +9 lines, -8 lines 1 comment Download
M runtime/vm/object.cc View 1 chunk +22 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
On 2015/07/30 13:45:22, Cutch wrote: > mailto:johnmccutchan@google.com changed reviewers: > + mailto:srdjan@google.com Fixed here: https://codereview.chromium.org/1268783002/
5 years, 4 months ago (2015-08-03 18:10:36 UTC) #2
srdjan
Please sync and upload again https://codereview.chromium.org/1260163006/diff/1/runtime/vm/flow_graph_compiler.cc File runtime/vm/flow_graph_compiler.cc (right): https://codereview.chromium.org/1260163006/diff/1/runtime/vm/flow_graph_compiler.cc#newcode527 runtime/vm/flow_graph_compiler.cc:527: if (false && FLAG_trace_inlining_intervals ...
5 years, 4 months ago (2015-08-03 19:03:36 UTC) #3
Cutch
5 years, 4 months ago (2015-08-03 19:14:09 UTC) #4
Message was sent while issue was closed.
On 2015/08/03 19:03:36, srdjan wrote:
> Please sync and upload again
> 
>
https://codereview.chromium.org/1260163006/diff/1/runtime/vm/flow_graph_compi...
> File runtime/vm/flow_graph_compiler.cc (right):
> 
>
https://codereview.chromium.org/1260163006/diff/1/runtime/vm/flow_graph_compi...
> runtime/vm/flow_graph_compiler.cc:527: if (false &&
> FLAG_trace_inlining_intervals && is_optimizing()) {
> remove false.

This CL is dead. No review necessary.

Powered by Google App Engine
This is Rietveld 408576698