Detect missing inliner

runtime/vm/flow_graph_compiler.cc

Index: runtime/vm/flow_graph_compiler.cc
diff --git a/runtime/vm/flow_graph_compiler.cc b/runtime/vm/flow_graph_compiler.cc
index 4e19dc3d9a9e39b6d3632c4e2dda88a255c66e8e..5a552b723b7d9d3f4d6ce38abd3ac97fc888e478 100644
--- a/runtime/vm/flow_graph_compiler.cc
+++ b/runtime/vm/flow_graph_compiler.cc
@@ -425,7 +425,7 @@ struct IntervalStruct {
   intptr_t inlining_id;
   IntervalStruct(intptr_t s, intptr_t id) : start(s), inlining_id(id) {}
   void Dump() {
-    OS::Print("start: %" Px " id: %" Pd "",  start, inlining_id);
+    ISL_Print("start: %" Px " id: %" Pd " ",  start, inlining_id);
   }
 };
 
@@ -515,6 +515,7 @@ void FlowGraphCompiler::VisitBlocks() {
     // truncate 'inline_id_to_function_'.
   }
 
+  LogBlock lb(Isolate::Current());
   if (is_optimizing()) {
     intervals.Add(IntervalStruct(prev_offset, prev_inlining_id));
     inlined_code_intervals_ =
@@ -523,11 +524,11 @@ void FlowGraphCompiler::VisitBlocks() {
     Smi& caller_inline_id = Smi::Handle();
     Smi& inline_id = Smi::Handle();
     for (intptr_t i = 0; i < intervals.length(); i++) {
-      if (FLAG_trace_inlining_intervals && is_optimizing()) {
+      if (false && FLAG_trace_inlining_intervals && is_optimizing()) {

[srdjan, 2015/08/03 19:03:36]

remove false.

         const Function* function =
             inline_id_to_function_.At(intervals[i].inlining_id);
         intervals[i].Dump();
-        OS::Print(" %s parent %" Pd "\n",
+        ISL_Print(" %s parent %" Pd "\n",
             function->ToQualifiedCString(),
             caller_inline_id_[intervals[i].inlining_id]);
       }
@@ -544,18 +545,18 @@ void FlowGraphCompiler::VisitBlocks() {
     }
   }
   set_current_block(NULL);
-  if (FLAG_trace_inlining_intervals && is_optimizing()) {
-    OS::Print("Intervals:\n");
+  if (false && FLAG_trace_inlining_intervals && is_optimizing()) {
+    ISL_Print("Intervals:\n");
     Smi& temp = Smi::Handle();
     for (intptr_t i = 0; i < inlined_code_intervals_.Length();
          i += Code::kInlIntNumEntries) {
       temp ^= inlined_code_intervals_.At(i + Code::kInlIntStart);
       ASSERT(!temp.IsNull());
-      OS::Print("% " Pd " start: %" Px " ", i, temp.Value());
+      ISL_Print("% " Pd " start: %" Px " ", i, temp.Value());
       temp ^= inlined_code_intervals_.At(i + Code::kInlIntInliningId);
-      OS::Print("inl-id: %" Pd " ", temp.Value());
+      ISL_Print("inl-id: %" Pd " ", temp.Value());
       temp ^= inlined_code_intervals_.At(i + Code::kInlIntCallerId);
-      OS::Print("caller-id: %" Pd " \n", temp.Value());
+      ISL_Print("caller-id: %" Pd " \n", temp.Value());
     }
   }
 }