Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1260163005: Appease jschuh@ by adding a field trial to move 'plugin' to blockable mixed content. (Closed)

Created:
5 years, 4 months ago by Mike West
Modified:
5 years, 4 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@settingh
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Appease jschuh@ by adding a field trial to move 'plugin' to blockable mixed content. BUG=513163 Committed: https://crrev.com/0d233e532109eee139970c3f481e16a0293ac4eb Cr-Commit-Position: refs/heads/master@{#342597}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/web_preferences.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/web_preferences.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1251243005 Patch 60001

Messages

Total messages: 9 (3 generated)
Mike West
Hey, look at that. Another CL.
5 years, 4 months ago (2015-07-30 13:40:45 UTC) #2
Mike West
Jochen, mind taking a look?
5 years, 4 months ago (2015-07-31 07:09:38 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 4 months ago (2015-07-31 07:10:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260163005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260163005/1
5 years, 4 months ago (2015-08-10 07:47:20 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-10 09:33:20 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 09:34:02 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0d233e532109eee139970c3f481e16a0293ac4eb
Cr-Commit-Position: refs/heads/master@{#342597}

Powered by Google App Engine
This is Rietveld 408576698