Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1251243005: Introduce a field trial to strictly block "blockable" mixed content. (Closed)

Created:
5 years, 5 months ago by Mike West
Modified:
5 years, 4 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce a field trial to strictly block "blockable" mixed content. This patch adds a field trial group to control the Blink-side "StrictlyBlockBlockableMixedContent" setting, which governs whether or not Blink asks its embedder whether or not blockable mixed content should load. This has the effect of disabling the mixed content shield UI completely for users who land in the field trial. The intent is to enable the trial for Canary and Dev, and see how it goes. blink-dev thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/1yWQaXmkXpA/BDV1-dC9su4J BUG=513163 R=jochen@chromium.org,philipj@opera.com Committed: https://crrev.com/2384c822ac23e8bd427c65ff5e7edd28d07f8b61 Cr-Commit-Position: refs/heads/master@{#341077}

Patch Set 1 #

Patch Set 2 : Options? Who needs options? #

Patch Set 3 : Finch. #

Patch Set 4 : Test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/web_preferences.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/web_preferences.cc View 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 26 (10 generated)
Mike West
Philip: This is what the //content side of the patch looks like. I'm sure it'll ...
5 years, 5 months ago (2015-07-23 13:42:21 UTC) #1
philipj_slow
I see, non-owner LGTM.
5 years, 5 months ago (2015-07-23 15:04:06 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251243005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1251243005/1
5 years, 5 months ago (2015-07-24 07:05:47 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/82393)
5 years, 5 months ago (2015-07-24 07:57:26 UTC) #6
Mike West
On 2015/07/24 at 07:57:26, commit-bot wrote: > Dry run: Try jobs failed on following builders: ...
5 years, 5 months ago (2015-07-24 08:35:52 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251243005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1251243005/20001
5 years, 5 months ago (2015-07-25 04:54:25 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-25 06:00:03 UTC) #11
Mike West
Hey Jochen! felt@ suggested locking this change behind finch, and rolling it out to Canary ...
5 years, 4 months ago (2015-07-29 14:45:12 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251243005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1251243005/40001
5 years, 4 months ago (2015-07-29 14:46:03 UTC) #15
jochen (gone - plz use gerrit)
lgtm
5 years, 4 months ago (2015-07-29 14:54:29 UTC) #16
felt
lgtm
5 years, 4 months ago (2015-07-29 15:08:14 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251243005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1251243005/60001
5 years, 4 months ago (2015-07-29 15:26:53 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-29 16:41:20 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251243005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1251243005/60001
5 years, 4 months ago (2015-07-30 05:31:00 UTC) #24
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 4 months ago (2015-07-30 07:26:52 UTC) #25
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 07:28:06 UTC) #26
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2384c822ac23e8bd427c65ff5e7edd28d07f8b61
Cr-Commit-Position: refs/heads/master@{#341077}

Powered by Google App Engine
This is Rietveld 408576698