Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1260013003: Reland of Fix FreeList::zapFreedMemory to fail "use-of-uninitialized-value" on MSAN (Closed)

Created:
5 years, 4 months ago by kojii
Modified:
5 years, 4 months ago
CC:
blink-reviews, Mads Ager (chromium), oilpan-reviews, blink-reviews-wtf_chromium.org, kouhei+heap_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Reland of Fix FreeList::zapFreedMemory to fail "use-of-uninitialized-value" on MSAN A CL for fallback font collection[1] broke MSAN bots[2] and was reverted. Another try to fix[2] also fails on MSAN bots at FreeList::zapFreeMemory[3]. This patch allows zapFreeMemory to write to uninitialized memory. Originally landed[4] and then reverted[5] due to missing support of a combination of #define symbols. [1] https://codereview.chromium.org/1241613006/ [2] https://codereview.chromium.org/1244973003/ [3] http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_msan_rel_ng/builds/84 [4] https://codereview.chromium.org/1259893002 [5] https://codereview.chromium.org/1257303003 BUG=514099 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199724

Patch Set 1 : Copied from https://codereview.chromium.org/1259893002 #

Patch Set 2 : Add defined(MEMORY_SANITIZER) missing only in .h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M Source/platform/heap/Heap.h View 1 2 chunks +9 lines, -2 lines 0 comments Download
M Source/platform/heap/Heap.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/wtf/AddressSanitizer.h View 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
kojii
PTAL. Sorry reviewers for troublesome, the previous CL had an embarrassing typo (#ifdef mismatch between ...
5 years, 4 months ago (2015-07-30 06:46:48 UTC) #2
haraken
LGTM
5 years, 4 months ago (2015-07-30 06:53:53 UTC) #3
tkent
lgtm
5 years, 4 months ago (2015-07-30 06:55:00 UTC) #4
Alexander Potapenko
LGTM
5 years, 4 months ago (2015-07-30 08:54:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260013003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260013003/20001
5 years, 4 months ago (2015-07-30 10:22:16 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 10:25:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199724

Powered by Google App Engine
This is Rietveld 408576698