Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1257303003: Revert of Fix FreeList::zapFreedMemory to fail "use-of-uninitialized-value" on MSAN (Closed)

Created:
5 years, 4 months ago by kojii
Modified:
5 years, 3 months ago
CC:
blink-reviews, Mads Ager (chromium), oilpan-reviews, blink-reviews-wtf_chromium.org, kouhei+heap_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Fix FreeList::zapFreedMemory to fail "use-of-uninitialized-value" on MSAN (patchset #9 id:160001 of https://codereview.chromium.org/1259893002/) Reason for revert: Strange, it passed MSAN try bot, but not the MSAN bots on waterfall...reverting. Original issue's description: > Fix FreeList::zapFreedMemory to fail "use-of-uninitialized-value" on MSAN > > A CL for fallback font collection[1] broke MSAN bots[2] and was reverted. > > Another try to fix[2] also fails on MSAN bots at > FreeList::zapFreeMemory[3]. This patch allows zapFreeMemory to write to > uninitialized memory. > > [1] https://codereview.chromium.org/1241613006/ > [2] https://codereview.chromium.org/1244973003/ > [3] http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_msan_rel_ng/builds/84 > > BUG=514099 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199701 TBR=haraken@chromium.org,glider@chromium.org,yutak@chromium.org,sigbjornf@opera.com,tkent@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=514099 Committed: https://crrev.com/cbb3e54d099ac3c2e63dd784288b522e44b69ffc git-svn-id: svn://svn.chromium.org/blink/trunk@199704 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -22 lines) Patch
M Source/platform/heap/Heap.h View 1 chunk +1 line, -8 lines 0 comments Download
M Source/platform/heap/Heap.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/wtf/AddressSanitizer.h View 3 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kojii
Created Revert of Fix FreeList::zapFreedMemory to fail "use-of-uninitialized-value" on MSAN
5 years, 4 months ago (2015-07-30 04:27:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257303003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257303003/1
5 years, 4 months ago (2015-07-30 04:28:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=199704
5 years, 4 months ago (2015-07-30 04:28:34 UTC) #3
tkent
lgtm
5 years, 4 months ago (2015-07-30 04:30:58 UTC) #4
haraken
LGTM
5 years, 4 months ago (2015-07-30 05:32:06 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 11:55:07 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbb3e54d099ac3c2e63dd784288b522e44b69ffc

Powered by Google App Engine
This is Rietveld 408576698