Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1259813002: clang/win/asan: Remove /fallback and enable warnings-as-errors. (Closed)

Created:
5 years, 5 months ago by Nico
Modified:
5 years, 4 months ago
Reviewers:
Reid Kleckner
CC:
chromium-reviews, hans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win/asan: Remove /fallback and enable warnings-as-errors. This removes the last case where we still needed /fallback. BUG=82385 Committed: https://crrev.com/0fa9d4fad367939eb0ac68b86914c6d86339da3c Cr-Commit-Position: refs/heads/master@{#340533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -9 lines 0 comments Download
M build/config/compiler/BUILD.gn View 2 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Nico
5 years, 5 months ago (2015-07-24 23:49:54 UTC) #2
Nico
rnk: ping :-)
5 years, 4 months ago (2015-07-27 18:16:57 UTC) #3
Reid Kleckner
lgtm Speaking of which, I should close that PR...
5 years, 4 months ago (2015-07-27 18:21:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259813002/1
5 years, 4 months ago (2015-07-27 18:22:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-27 19:43:55 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-07-27 19:44:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fa9d4fad367939eb0ac68b86914c6d86339da3c
Cr-Commit-Position: refs/heads/master@{#340533}

Powered by Google App Engine
This is Rietveld 408576698