Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1852)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1259813002: clang/win/asan: Remove /fallback and enable warnings-as-errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index af14840f414ee597b884d69ab350955d848a29cd..4cc958c8ac437f7d7a5f9a065fb574e61a68baf7 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -130,10 +130,6 @@ config("compiler") {
cflags += [ "-m64" ]
}
- # TODO(thakis): Remove this once llvm.org/PR24167 is fixed.
- if (is_asan) {
- cflags += [ "/fallback" ]
- }
if (exec_script("//build/win/use_ansi_codes.py", [], "trim string") ==
"True") {
cflags += [
@@ -715,12 +711,10 @@ config("runtime_library") {
default_warning_flags = []
default_warning_flags_cc = []
if (is_win) {
- # TODO(thakis): Make this unconditional once llvm.org/PR24167 is fixed.
- if (!is_clang || !is_asan) {
- default_warning_flags += [ "/WX" ] # Treat warnings as errors.
- }
-
default_warning_flags += [
+ # Treat warnings as errors.
+ "/WX",
+
# Warnings permanently disabled:
# TODO(GYP) The GYP build doesn't have this globally enabled but disabled
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698