build/common.gypi - Issue 1259813002: clang/win/asan: Remove /fallback and enable warnings-as-errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 1259813002: clang/win/asan: Remove /fallback and enable warnings-as-errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 038c11d89e79da035f2a3604266a55f49c7230f8..24368fb3e9f2a71ffb9e1a41f00742032e78aa57 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -5743,15 +5743,6 @@

}],

- ['clang==1 and target_arch=="ia32" and asan==1', {

- # TODO(thakis): Remove this block once llvm.org/PR24167 is fixed.

- 'VCCLCompilerTool': {

- 'WarnAsError': 'false',

- 'AdditionalOptions': [

- '/fallback',

- ],

- },

- }],

['clang==1 and clang_use_chrome_plugins==1', {

'VCCLCompilerTool': {

'AdditionalOptions': [

« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »