Issue 1259763013: Devtools: add ServeLocalDirectories().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1259763013: Devtools: add ServeLocalDirectories(). (Closed)

Created:
5 years, 4 months ago by ppi

Modified:
5 years, 4 months ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Devtools: add ServeLocalDirectories(). This takes a list of mappings, instead of single directory path, and will be used to configure development servers defined in a config file. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4b0acc5be3e218b59a47a267525d845eaeb2a2cb

Patch Set 1 #

Patch Set 2 : Clarify documentation. #

Patch Set 3 : Add one more comment. #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -30 lines)			Patch
M	mojo/devtools/common/devtoolslib/android_shell.py	View	1	2 chunks	+26 lines, -7 lines	0 comments	Download
M	mojo/devtools/common/devtoolslib/http_server.py	View	1	2 chunks	+8 lines, -11 lines	0 comments	Download
M	mojo/devtools/common/devtoolslib/linux_shell.py	View	1	2 chunks	+22 lines, -7 lines	0 comments	Download
M	mojo/devtools/common/devtoolslib/shell.py	View	1 2	2 chunks	+20 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ppi

Hi Ben, clarified the documentation as discussed offline. ptal.

5 years, 4 months ago (2015-08-03 11:52:04 UTC) #3

ppi

5 years, 4 months ago (2015-08-03 13:08:56 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
4b0acc5be3e218b59a47a267525d845eaeb2a2cb (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages