Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1152)

Unified Diff: mojo/devtools/common/devtoolslib/linux_shell.py

Issue 1259763013: Devtools: add ServeLocalDirectories(). (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Add one more comment. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/devtools/common/devtoolslib/http_server.py ('k') | mojo/devtools/common/devtoolslib/shell.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/devtools/common/devtoolslib/linux_shell.py
diff --git a/mojo/devtools/common/devtoolslib/linux_shell.py b/mojo/devtools/common/devtoolslib/linux_shell.py
index a8c25dfa1051dec679a40bc0a4102f16f0e3124f..fff21a74dab4dd5241a1a60c25ab7842e2864ce5 100644
--- a/mojo/devtools/common/devtoolslib/linux_shell.py
+++ b/mojo/devtools/common/devtoolslib/linux_shell.py
@@ -22,8 +22,7 @@ class LinuxShell(Shell):
self.executable_path = executable_path
self.command_prefix = command_prefix if command_prefix else []
- def ServeLocalDirectory(self, local_dir_path, port=0,
- additional_mappings=None):
+ def ServeLocalDirectory(self, local_dir_path, port=0):
"""Serves the content of the local (host) directory, making it available to
the shell under the url returned by the function.
@@ -33,15 +32,31 @@ class LinuxShell(Shell):
Args:
local_dir_path: path to the directory to be served
port: port at which the server will be available to the shell
- additional_mappings: List of tuples (prefix, local_base_path) mapping
- URLs that start with |prefix| to local directory at |local_base_path|.
- The prefixes should skip the leading slash.
Returns:
The url that the shell can use to access the content of |local_dir_path|.
"""
- return 'http://%s:%d/' % http_server.start_http_server(local_dir_path, port,
- additional_mappings)
+ mappings = [('', local_dir_path)]
+ return 'http://%s:%d/' % http_server.start_http_server(mappings, port)
+
+ def ServeLocalDirectories(self, mappings, port=0):
+ """Serves the content of the local (host) directories, making it available
+ to the shell under the url returned by the function.
+
+ The server will run on a separate thread until the program terminates. The
+ call returns immediately.
+
+ Args:
+ mappings: List of tuples (prefix, local_base_path) mapping URLs that start
+ with |prefix| to local directory at |local_base_path|. The prefixes
+ should skip the leading slash. The first matching prefix will be used
+ each time.
+ port: port at which the server will be available to the shell
+
+ Returns:
+ The url that the shell can use to access the content of |local_dir_path|.
+ """
+ return 'http://%s:%d/' % http_server.start_http_server(mappings, port)
def ForwardHostPortToShell(self, host_port):
"""Forwards a port on the host machine to the same port wherever the shell
« no previous file with comments | « mojo/devtools/common/devtoolslib/http_server.py ('k') | mojo/devtools/common/devtoolslib/shell.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698