Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Unified Diff: mojo/devtools/common/devtoolslib/android_shell.py

Issue 1259763013: Devtools: add ServeLocalDirectories(). (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Add one more comment. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/devtools/common/devtoolslib/http_server.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/devtools/common/devtoolslib/android_shell.py
diff --git a/mojo/devtools/common/devtoolslib/android_shell.py b/mojo/devtools/common/devtoolslib/android_shell.py
index 7a7436f17e94d2b3294a651f2dcea2eeb242c8d7..2d87f4efb97886eb2bb8f09a9391e351e25d2973 100644
--- a/mojo/devtools/common/devtoolslib/android_shell.py
+++ b/mojo/devtools/common/devtoolslib/android_shell.py
@@ -370,8 +370,7 @@ class AndroidShell(Shell):
logcat_watch_thread = threading.Thread(target=_ForwardObservatoriesAsNeeded)
logcat_watch_thread.start()
- def ServeLocalDirectory(self, local_dir_path, port=0,
- additional_mappings=None):
+ def ServeLocalDirectory(self, local_dir_path, port=0):
"""Serves the content of the local (host) directory, making it available to
the shell under the url returned by the function.
@@ -381,16 +380,36 @@ class AndroidShell(Shell):
Args:
local_dir_path: path to the directory to be served
port: port at which the server will be available to the shell
- additional_mappings: List of tuples (prefix, local_base_path) mapping
- URLs that start with |prefix| to local directory at |local_base_path|.
- The prefixes should skip the leading slash.
Returns:
The url that the shell can use to access the content of |local_dir_path|.
"""
assert local_dir_path
- server_address = start_http_server(local_dir_path, host_port=port,
- additional_mappings=additional_mappings)
+ mappings = [('', local_dir_path)]
+ server_address = start_http_server(mappings, host_port=port)
+
+ return 'http://127.0.0.1:%d/' % self._ForwardDevicePortToHost(
+ port, server_address[1])
+
+ def ServeLocalDirectories(self, mappings, port=0):
+ """Serves the content of the local (host) directories, making it available
+ to the shell under the url returned by the function.
+
+ The server will run on a separate thread until the program terminates. The
+ call returns immediately.
+
+ Args:
+ mappings: List of tuples (prefix, local_base_path) mapping URLs that start
+ with |prefix| to local directory at |local_base_path|. The prefixes
+ should skip the leading slash. The first matching prefix will be used
+ each time.
+ port: port at which the server will be available to the shell
+
+ Returns:
+ The url that the shell can use to access the content of |local_dir_path|.
+ """
+ assert mappings
+ server_address = start_http_server(mappings, host_port=port)
return 'http://127.0.0.1:%d/' % self._ForwardDevicePortToHost(
port, server_address[1])
« no previous file with comments | « no previous file | mojo/devtools/common/devtoolslib/http_server.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698