Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1259333004: [MediaRouter]Wires up issue manager in MediaRouterMojoImpl. (Closed)

Created:
5 years, 4 months ago by haibinlu
Modified:
5 years, 4 months ago
Reviewers:
imcheng, Kevin M
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, Aaron Boodman, posciak+watch_chromium.org, ben+mojo_chromium.org, viettrungluu+watch_chromium.org, mcasas+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, media-router+watch_chromium.org, darin (slow to review), wjia+watch_chromium.org, apacible
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MediaRouter]Wires up issue manager in MediaRouterMojoImpl. bug=515162 Committed: https://crrev.com/9b573e7f018bc96d6e7bcc6b8366cc715b83f75c Cr-Commit-Position: refs/heads/master@{#341227}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 8

Patch Set 3 : #

Patch Set 4 : #

Total comments: 6

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -10 lines) Patch
M chrome/browser/media/router/issue.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/router/media_router_mojo_impl.h View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/media/router/media_router_mojo_impl.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/media/router/media_router_mojo_impl_unittest.cc View 1 2 3 4 4 chunks +46 lines, -0 lines 0 comments Download
M chrome/browser/media/router/test_helper.h View 1 2 3 4 2 chunks +43 lines, -0 lines 0 comments Download
M chrome/browser/media/router/test_helper.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
haibinlu
5 years, 4 months ago (2015-07-29 01:08:54 UTC) #2
imcheng
lgtm Can you add a reference to the tracking crbug please? We also have to ...
5 years, 4 months ago (2015-07-29 01:49:38 UTC) #3
haibinlu
Issue was already wired up to the UI https://codereview.chromium.org/1259333004/diff/1/chrome/browser/media/router/media_router_mojo_impl_unittest.cc File chrome/browser/media/router/media_router_mojo_impl_unittest.cc (right): https://codereview.chromium.org/1259333004/diff/1/chrome/browser/media/router/media_router_mojo_impl_unittest.cc#newcode69 chrome/browser/media/router/media_router_mojo_impl_unittest.cc:69: mojoIssue ...
5 years, 4 months ago (2015-07-29 17:24:15 UTC) #4
Kevin M
https://codereview.chromium.org/1259333004/diff/20001/chrome/browser/media/router/media_router_mojo_impl.h File chrome/browser/media/router/media_router_mojo_impl.h (right): https://codereview.chromium.org/1259333004/diff/20001/chrome/browser/media/router/media_router_mojo_impl.h#newcode178 chrome/browser/media/router/media_router_mojo_impl.h:178: IssueManager issue_manager_; Make this a pointer so it can ...
5 years, 4 months ago (2015-07-29 17:41:49 UTC) #5
haibinlu
PTAL https://codereview.chromium.org/1259333004/diff/20001/chrome/browser/media/router/media_router_mojo_impl.h File chrome/browser/media/router/media_router_mojo_impl.h (right): https://codereview.chromium.org/1259333004/diff/20001/chrome/browser/media/router/media_router_mojo_impl.h#newcode178 chrome/browser/media/router/media_router_mojo_impl.h:178: IssueManager issue_manager_; On 2015/07/29 17:41:49, Kevin M wrote: ...
5 years, 4 months ago (2015-07-29 18:46:08 UTC) #6
Kevin M
lgtm https://codereview.chromium.org/1259333004/diff/60001/chrome/browser/media/router/media_router_mojo_impl_unittest.cc File chrome/browser/media/router/media_router_mojo_impl_unittest.cc (right): https://codereview.chromium.org/1259333004/diff/60001/chrome/browser/media/router/media_router_mojo_impl_unittest.cc#newcode287 chrome/browser/media/router/media_router_mojo_impl_unittest.cc:287: .Times(1) Times(1)/WillRepeatedly can become WillOnce https://codereview.chromium.org/1259333004/diff/60001/chrome/browser/media/router/media_router_mojo_impl_unittest.cc#newcode291 chrome/browser/media/router/media_router_mojo_impl_unittest.cc:291: .Times(1); ...
5 years, 4 months ago (2015-07-30 17:18:42 UTC) #7
haibinlu
https://codereview.chromium.org/1259333004/diff/60001/chrome/browser/media/router/media_router_mojo_impl_unittest.cc File chrome/browser/media/router/media_router_mojo_impl_unittest.cc (right): https://codereview.chromium.org/1259333004/diff/60001/chrome/browser/media/router/media_router_mojo_impl_unittest.cc#newcode287 chrome/browser/media/router/media_router_mojo_impl_unittest.cc:287: .Times(1) On 2015/07/30 17:18:42, Kevin M wrote: > Times(1)/WillRepeatedly ...
5 years, 4 months ago (2015-07-30 21:00:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259333004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259333004/80001
5 years, 4 months ago (2015-07-30 21:00:45 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/34128)
5 years, 4 months ago (2015-07-30 22:12:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259333004/80002 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259333004/80002
5 years, 4 months ago (2015-07-30 22:56:27 UTC) #16
commit-bot: I haz the power
Committed patchset #6 (id:80002)
5 years, 4 months ago (2015-07-30 23:54:27 UTC) #17
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 23:54:57 UTC) #18
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/9b573e7f018bc96d6e7bcc6b8366cc715b83f75c
Cr-Commit-Position: refs/heads/master@{#341227}

Powered by Google App Engine
This is Rietveld 408576698