[MediaRouter]Wires up issue manager in MediaRouterMojoImpl.

chrome/browser/media/router/media_router_mojo_impl.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTER_MOJO_IMPL_H_
 #define CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTER_MOJO_IMPL_H_
 
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/containers/hash_tables.h"
 #include "base/containers/scoped_ptr_hash_map.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/observer_list.h"
 #include "base/thread_task_runner_handle.h"
 #include "base/threading/thread_checker.h"
 #include "chrome/browser/media/router/issue.h"
+#include "chrome/browser/media/router/issue_manager.h"
 #include "chrome/browser/media/router/media_router.h"
 #include "chrome/browser/media/router/media_router.mojom.h"
 
 namespace content {
 class BrowserContext;
 }
 
 namespace extensions {
 class EventPageTracker;
 }
@@ skipping 104 matching lines @@
                             const std::string& message,
                             const SendRouteMessageCallback& callback);
   void DoListenForRouteMessages(
       const std::vector<MediaRoute::Id>& route_ids,
       const PresentationSessionMessageCallback& message_cb);
   void DoClearIssue(const Issue::Id& issue_id);
   void DoStartObservingMediaSinks(const MediaSource::Id& source_id);
   void DoStopObservingMediaSinks(const MediaSource::Id& source_id);
   void DoStartObservingMediaRoutes();
   void DoStopObservingMediaRoutes();
-  void DoStartObservingIssues();
-  void DoStopObservingIssues();
 
   // Invoked when the next batch of messages arrives.
   // |messages|: A list of messages received.
   // |message_cb|: The callback to invoke to pass on the messages received.
   void OnRouteMessageReceived(
       const PresentationSessionMessageCallback& message_cb,
       mojo::Array<interfaces::RouteMessagePtr> messages);
 
   // Error handler callback for |binding_| and |media_route_provider_|.
   void OnConnectionError();
@@ skipping 11 matching lines @@
   // Pending requests queued to be executed once component extension
   // becomes ready.
   std::vector<base::Closure> pending_requests_;
 
   base::ScopedPtrHashMap<MediaSource::Id,
                          scoped_ptr<base::ObserverList<MediaSinksObserver>>>
       sinks_observers_;
 
   base::ObserverList<MediaRoutesObserver> routes_observers_;
 
+  IssueManager issue_manager_;

[Kevin M, 2015/07/29 17:41:49]

Make this a pointer so it can accept a mock

[haibinlu, 2015/07/29 18:46:07]

Discussed with Derek, we feel that the cost of mocking issue manager is high in
order to test simple logic.

+
   // Binds |this| to a Mojo connection stub for interfaces::MediaRouter.
   scoped_ptr<mojo::Binding<interfaces::MediaRouter>> binding_;
 
   // Mojo proxy object for the Media Route Provider Manager.
   // Set to null initially, and later set to the Provider Manager proxy object
   // passed in via |RegisterMediaRouteProvider()|.
   // This is set to null again when the component extension is suspended
   // if or a Mojo channel error occured.
   interfaces::MediaRouteProviderPtr media_route_provider_;
 
@@ skipping 12 matching lines @@
   std::string instance_id_;
 
   base::ThreadChecker thread_checker_;
 
   DISALLOW_COPY_AND_ASSIGN(MediaRouterMojoImpl);
 };
 
 }  // namespace media_router
 
 #endif  // CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTER_MOJO_IMPL_H_