Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2310)

Unified Diff: chrome/browser/media/router/media_router_mojo_impl.cc

Issue 1259333004: [MediaRouter]Wires up issue manager in MediaRouterMojoImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/media_router_mojo_impl.cc
diff --git a/chrome/browser/media/router/media_router_mojo_impl.cc b/chrome/browser/media/router/media_router_mojo_impl.cc
index 976b0eeb70d8ccfb8e3a220ef0bc170bc2c08eff..e34d36ad711fb49c0a928d2b023dc537134c74bd 100644
--- a/chrome/browser/media/router/media_router_mojo_impl.cc
+++ b/chrome/browser/media/router/media_router_mojo_impl.cc
@@ -10,6 +10,7 @@
#include "base/memory/scoped_vector.h"
#include "base/observer_list.h"
#include "base/strings/stringprintf.h"
+#include "chrome/browser/media/router/issues_observer.h"
#include "chrome/browser/media/router/media_router_factory.h"
#include "chrome/browser/media/router/media_router_type_converters.h"
#include "chrome/browser/media/router/media_routes_observer.h"
@@ -143,9 +144,10 @@ void MediaRouterMojoImpl::RegisterMediaRouteProvider(
}
void MediaRouterMojoImpl::OnIssue(const interfaces::IssuePtr issue) {
- // TODO(imcheng): Implement. (crbug.com/461815)
DCHECK(thread_checker_.CalledOnValidThread());
- NOTIMPLEMENTED();
+ DVLOG_WITH_INSTANCE(1) << "OnIssue " << issue->title;
+ const Issue& issue_converted = issue.To<Issue>();
+ issue_manager_.AddIssue(issue_converted);
}
void MediaRouterMojoImpl::OnSinksReceived(
@@ -254,7 +256,7 @@ void MediaRouterMojoImpl::ListenForRouteMessages(
void MediaRouterMojoImpl::ClearIssue(const Issue::Id& issue_id) {
DCHECK(thread_checker_.CalledOnValidThread());
-
+ issue_manager_.ClearIssue(issue_id);
RunOrDefer(base::Bind(&MediaRouterMojoImpl::DoClearIssue,
base::Unretained(this), issue_id));
}
@@ -328,13 +330,13 @@ void MediaRouterMojoImpl::UnregisterMediaRoutesObserver(
}
void MediaRouterMojoImpl::RegisterIssuesObserver(IssuesObserver* observer) {
- // TODO(imcheng): Implement. (crbug.com/461815)
- NOTIMPLEMENTED();
+ DCHECK(thread_checker_.CalledOnValidThread());
+ issue_manager_.RegisterObserver(observer);
}
void MediaRouterMojoImpl::UnregisterIssuesObserver(IssuesObserver* observer) {
- // TODO(imcheng): Implement. (crbug.com/461815)
- NOTIMPLEMENTED();
+ DCHECK(thread_checker_.CalledOnValidThread());
+ issue_manager_.UnregisterObserver(observer);
}
void MediaRouterMojoImpl::DoCreateRoute(
« no previous file with comments | « chrome/browser/media/router/media_router_mojo_impl.h ('k') | chrome/browser/media/router/media_router_mojo_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698