Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1259213003: Ensure that title and state updating works without page id. (Closed)

Created:
5 years, 4 months ago by Avi (use Gerrit)
Modified:
5 years, 4 months ago
Reviewers:
nasko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure that title and state updating works without page id. BUG=369661 TEST=everything stays green CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/4a1c1980e95fe8cd36f7b2910757ace3b8970aa0 Cr-Commit-Position: refs/heads/master@{#340960}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259213003/1
5 years, 4 months ago (2015-07-29 14:21:11 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-29 15:08:31 UTC) #4
Avi (use Gerrit)
5 years, 4 months ago (2015-07-29 18:29:17 UTC) #6
nasko
LGTM
5 years, 4 months ago (2015-07-29 19:43:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259213003/1
5 years, 4 months ago (2015-07-29 19:51:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-29 19:59:00 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4a1c1980e95fe8cd36f7b2910757ace3b8970aa0 Cr-Commit-Position: refs/heads/master@{#340960}
5 years, 4 months ago (2015-07-29 20:00:05 UTC) #11
Avi (use Gerrit)
5 years, 4 months ago (2015-07-30 20:40:20 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1254423007/ by avi@chromium.org.

The reason for reverting is: Title updating isn't working; revert for now..

Powered by Google App Engine
This is Rietveld 408576698