Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1259213003: Ensure that title and state updating works without page id. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 4ff481b2dcc5f5b1251ecc74f8b6c665546efd28..794f2f288a9e1f06d4cd32d9024dfc9e283071e5 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -3839,7 +3839,7 @@ void WebContentsImpl::UpdateState(RenderViewHost* rvh,
// method.
entry = new_entry;
} else {
- DCHECK_EQ(entry, new_entry);
+ CHECK_EQ(entry, new_entry);
}
if (page_state == entry->GetPageState())
@@ -4019,7 +4019,7 @@ void WebContentsImpl::UpdateTitle(RenderFrameHost* render_frame_host,
static_cast<RenderViewHostImpl*>(render_frame_host->GetRenderViewHost());
NavigationEntryImpl* new_entry = controller_.GetEntryWithUniqueID(
rvhi->nav_entry_id());
- DCHECK_EQ(entry, new_entry);
+ CHECK_EQ(entry, new_entry);
// We can handle title updates when we don't have an entry in
// UpdateTitleForEntry, but only if the update is from the current RVH.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698