GN (Android): Make is_clang work for (at least for arm32)

build/config/compiler/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/chrome_build.gni")
 if (current_cpu == "arm") {
   import("//build/config/arm.gni")
 }
 if (current_cpu == "mipsel" || current_cpu == "mips64el") {
@@ skipping 149 matching lines @@
 
       # Not exporting C++ inline functions can generally be applied anywhere
       # so we do so here. Normal function visibility is controlled by
       # //build/config/gcc:symbol_visibility_hidden.
       "-fvisibility-inlines-hidden",
     ]
 
     # Stack protection.
     if (is_mac) {
       cflags += [ "-fstack-protector-all" ]
-    } else if (is_linux) {
-      cflags += [
-        "-fstack-protector",
-        "--param=ssp-buffer-size=4",
-      ]
+    } else if (is_posix && !is_chromeos && !is_nacl) {
+      # TODO(phajdan.jr): Use -fstack-protector-strong when our gcc supports it.
+      cflags += [ "--param=ssp-buffer-size=4" ]
+      if (is_android && (current_cpu == "arm64" || current_cpu == "x86")) {
+        cflags += [ "-fno-stack-protector" ]
+      } else {
+        cflags += [ "-fstack-protector" ]
+      }
     }
 
     # Linker warnings.
     if (!(is_chromeos && current_cpu == "arm") && !is_mac && !is_ios) {
       # TODO(jochen): Enable this on chromeos on arm. http://crbug.com/356580
       ldflags += [ "-Wl,--fatal-warnings" ]
     }
 
     # Common options for AddressSanitizer, LeakSanitizer, ThreadSanitizer and
     # MemorySanitizer
@@ skipping 330 matching lines @@
   }
 
   # Android-specific flags setup.
   # -----------------------------
   if (is_android) {
     cflags += [
       "-ffunction-sections",
       "-funwind-tables",
       "-fno-short-enums",
     ]
-    if (!is_clang) {
+    if (is_clang) {
+      rebased_android_toolchain_root =
+          rebase_path(android_toolchain_root, root_build_dir)
+      cflags += [
+        # TODO(hans) Enable integrated-as (crbug.com/124610).
+        "-no-integrated-as",
+        "-B${rebased_android_toolchain_root}/bin",  # Else /usr/bin/as gets picked up.
+      ]
+    } else {
       # Clang doesn't support these flags.
       cflags += [ "-finline-limit=64" ]
     }
     if (is_asan) {
       # Android build relies on -Wl,--gc-sections removing unreachable code.
       # ASan instrumentation for globals inhibits this and results in a library
       # with unresolvable relocations.
       # TODO(eugenis): find a way to reenable this.
       cflags += [ "-mllvm -asan-globals=0" ]
     }
 
     defines += [ "ANDROID" ]
 
     # The NDK has these things, but doesn't define the constants
     # to say that it does. Define them here instead.
     defines += [ "HAVE_SYS_UIO_H" ]
 
     # Use gold for Android for most CPU architectures.
     if (current_cpu == "x86" || current_cpu == "x64" || current_cpu == "arm") {
       ldflags += [ "-fuse-ld=gold" ]
       if (is_clang) {
         # Let clang find the ld.gold in the NDK.
-        ldflags += [ "--gcc-toolchain=" +
-                     rebase_path(android_toolchain_root, root_build_dir) ]
+        ldflags += [ "--gcc-toolchain=$rebased_android_toolchain_root" ]
       }
     }
 
     ldflags += [
       "-Wl,--no-undefined",
 
       # Don't allow visible symbols from libgcc or libc++ to be
       # re-exported.
       "-Wl,--exclude-libs=libgcc.a",
       "-Wl,--exclude-libs=libc++_static.a",
 
       # Don't allow visible symbols from libraries that contain
       # assembly code with symbols that aren't hidden properly.
       # http://crbug.com/448386
       "-Wl,--exclude-libs=libvpx_assembly_arm.a",
     ]
     if (current_cpu == "arm") {
       ldflags += [
         # Enable identical code folding to reduce size.
         "-Wl,--icf=safe",
       ]
     }
 
     if (is_clang) {
       if (current_cpu == "arm") {
-        cflags += [ "-target arm-linux-androideabi" ]
-        ldflags += [ "-target arm-linux-androideabi" ]
+        cflags += [
+          "-target",
+          "arm-linux-androideabi",
+        ]
+        ldflags += [
+          "-target",
+          "arm-linux-androideabi",
+        ]
       } else if (current_cpu == "x86") {
-        cflags += [ "-target i686-linux-androideabi" ]
-        ldflags += [ "-target i686-linux-androideabi" ]
+        cflags += [
+          "-target",
+          "i686-linux-androideabi",
+        ]
+        ldflags += [
+          "-target",
+          "i686-linux-androideabi",
+        ]
       }
     }
   }
 
   # Pass the same C/C++ flags to the objective C/C++ compiler.
   cflags_objc += cflags_c
   cflags_objcc += cflags_cc
 }
 
 config("compiler_arm_fpu") {
@@ skipping 250 matching lines @@
       # availability is newer than the deployment target. This is not
       # required when compiling Chrome for iOS.
       default_warning_flags += [ "-Wpartial-availability" ]
     }
   }
 
   if (gcc_version >= 48) {
     default_warning_flags_cc += [
       # See comment for -Wno-c++11-narrowing.
       "-Wno-narrowing",
-
-      # TODO(thakis): Remove, http://crbug.com/263960
-      "-Wno-literal-suffix",
     ]
+    if (!is_clang) {
+      default_warning_flags_cc += [
+        # TODO(thakis): Remove, http://crbug.com/263960
+        "-Wno-literal-suffix",
+      ]
+    }
   }
 
   # Suppress warnings about ABI changes on ARM (Clang doesn't give this
   # warning).
   if (current_cpu == "arm" && !is_clang) {
     default_warning_flags += [ "-Wno-psabi" ]
   }
 
   if (is_android) {
     # Disable any additional warnings enabled by the Android build system but
@@ skipping 417 matching lines @@
       cflags += [ "-gsplit-dwarf" ]
     }
   }
 }
 
 config("no_symbols") {
   if (!is_win) {
     cflags = [ "-g0" ]
   }
 }