Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1258693005: [css-flexbox] Correctly determine whether a percentage height is definite (Closed)

Created:
5 years, 4 months ago by cbiesinger
Modified:
5 years, 4 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[css-flexbox] Correctly determine whether a percentage height is definite Use child.computePercentageHeight to answer the question on whether a flex-basis is definite. This correctly handles the case where a flexbox is absolutely positioned, which should be considered definite when computing children's percentage sizes (but not when computing the flexbox size itself). hasDefiniteLogicalHeight should be changed/removed but that is a separate issue. R=leviw@chromium.org,ojan@chromium.org BUG=476840 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200013

Patch Set 1 #

Patch Set 2 : now it compiles #

Patch Set 3 : need negation #

Patch Set 4 : fix tests #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -15 lines) Patch
M LayoutTests/css3/flexbox/auto-height-with-flex.html View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
A LayoutTests/css3/flexbox/percentage-height-in-abspos.html View 1 chunk +45 lines, -0 lines 0 comments Download
A LayoutTests/css3/flexbox/percentage-height-in-abspos-expected.html View 1 chunk +45 lines, -0 lines 0 comments Download
M LayoutTests/css3/flexbox/percentage-sizes-quirks.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutFlexibleBox.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/layout/LayoutFlexibleBox.cpp View 1 2 3 4 chunks +13 lines, -10 lines 2 comments Download

Messages

Total messages: 7 (1 generated)
cbiesinger
5 years, 4 months ago (2015-08-04 23:33:31 UTC) #1
cbiesinger
see also https://codereview.chromium.org/1081433005/ where I tried to fix this in a different way, but that ...
5 years, 4 months ago (2015-08-04 23:34:46 UTC) #2
leviw_travelin_and_unemployed
lgtm https://codereview.chromium.org/1258693005/diff/60001/Source/core/layout/LayoutFlexibleBox.cpp File Source/core/layout/LayoutFlexibleBox.cpp (right): https://codereview.chromium.org/1258693005/diff/60001/Source/core/layout/LayoutFlexibleBox.cpp#newcode594 Source/core/layout/LayoutFlexibleBox.cpp:594: bool LayoutFlexibleBox::mainAxisLengthIsIndefinite(LayoutBox& child, const Length& flexBasis) const Maybe ...
5 years, 4 months ago (2015-08-05 00:06:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258693005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258693005/60001
5 years, 4 months ago (2015-08-05 00:14:36 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://src.chromium.org/viewvc/blink?view=rev&revision=200013
5 years, 4 months ago (2015-08-05 01:21:48 UTC) #6
cbiesinger
5 years, 4 months ago (2015-08-05 04:46:38 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1258693005/diff/60001/Source/core/layout/Layo...
File Source/core/layout/LayoutFlexibleBox.cpp (right):

https://codereview.chromium.org/1258693005/diff/60001/Source/core/layout/Layo...
Source/core/layout/LayoutFlexibleBox.cpp:594: bool
LayoutFlexibleBox::mainAxisLengthIsIndefinite(LayoutBox& child, const Length&
flexBasis) const
On 2015/08/05 00:06:25, leviw wrote:
> Maybe a TODO change this to definite :p

https://codereview.chromium.org/1268253002/

Powered by Google App Engine
This is Rietveld 408576698