Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: Source/core/layout/LayoutFlexibleBox.h

Issue 1258693005: [css-flexbox] Correctly determine whether a percentage height is definite (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix tests Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/layout/LayoutFlexibleBox.h
diff --git a/Source/core/layout/LayoutFlexibleBox.h b/Source/core/layout/LayoutFlexibleBox.h
index 5620dc69b4d8d40127087a833df206af58f22f8c..163836c1c762afc69afa10ed2b81d211cbee02cc 100644
--- a/Source/core/layout/LayoutFlexibleBox.h
+++ b/Source/core/layout/LayoutFlexibleBox.h
@@ -101,7 +101,6 @@ private:
LayoutUnit crossAxisIntrinsicExtentForChild(LayoutBox& child) const;
LayoutUnit childIntrinsicHeight(LayoutBox& child) const;
LayoutUnit childIntrinsicWidth(LayoutBox& child) const;
- bool mainAxisExtentIsDefinite() const;
LayoutUnit mainAxisExtentForChild(LayoutBox& child) const;
LayoutUnit crossAxisExtent() const;
LayoutUnit mainAxisExtent() const;
@@ -130,7 +129,7 @@ private:
ItemPosition alignmentForChild(LayoutBox& child) const;
LayoutUnit mainAxisBorderAndPaddingExtentForChild(LayoutBox& child) const;
LayoutUnit computeInnerFlexBaseSizeForChild(LayoutBox& child, ChildLayoutType = LayoutIfNeeded);
- bool mainAxisLengthIsIndefinite(const Length& flexBasis) const;
+ bool mainAxisLengthIsIndefinite(LayoutBox& child, const Length& flexBasis) const;
bool childFlexBaseSizeRequiresLayout(LayoutBox& child) const;
bool needToStretchChildLogicalHeight(LayoutBox& child) const;
EOverflow mainAxisOverflowForChild(LayoutBox& child) const;

Powered by Google App Engine
This is Rietveld 408576698