Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 1257823006: Fixing issues using TexStorage2D with compressed textures (Closed)

Created:
5 years, 4 months ago by bajones
Modified:
5 years, 3 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fixing issues using TexStorage2D with compressed textures BUG=295792 Committed: https://crrev.com/fb8c49609d8da81dc1d916df5f8e69c47d18d7a7 git-svn-id: svn://svn.chromium.org/blink/trunk@199688 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -73 lines) Patch
M Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 chunk +1 line, -1 line 1 comment Download
M Source/modules/webgl/WebGLTexture.cpp View 1 chunk +14 lines, -72 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
bajones
PTAL! Helps with the teleporter demo. https://codereview.chromium.org/1257823006/diff/1/Source/modules/webgl/WebGLTexture.cpp File Source/modules/webgl/WebGLTexture.cpp (left): https://codereview.chromium.org/1257823006/diff/1/Source/modules/webgl/WebGLTexture.cpp#oldcode591 Source/modules/webgl/WebGLTexture.cpp:591: GLenum WebGLTexture::getValidFormatForInternalFormat(GLenum internalFormat) ...
5 years, 4 months ago (2015-07-29 20:11:03 UTC) #2
Zhenyao Mo
LGTM to unblock you for the demo https://codereview.chromium.org/1257823006/diff/1/Source/modules/webgl/WebGLRenderingContextBase.cpp File Source/modules/webgl/WebGLRenderingContextBase.cpp (right): https://codereview.chromium.org/1257823006/diff/1/Source/modules/webgl/WebGLRenderingContextBase.cpp#newcode1827 Source/modules/webgl/WebGLRenderingContextBase.cpp:1827: if (!isWebGL2OrHigher() ...
5 years, 4 months ago (2015-07-29 20:57:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257823006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257823006/1
5 years, 4 months ago (2015-07-29 21:46:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=199688
5 years, 4 months ago (2015-07-30 00:03:11 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 11:54:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb8c49609d8da81dc1d916df5f8e69c47d18d7a7

Powered by Google App Engine
This is Rietveld 408576698