Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2104)

Unified Diff: Source/modules/webgl/WebGLRenderingContextBase.cpp

Issue 1257823006: Fixing issues using TexStorage2D with compressed textures (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/modules/webgl/WebGLTexture.cpp » ('j') | Source/modules/webgl/WebGLTexture.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webgl/WebGLRenderingContextBase.cpp
diff --git a/Source/modules/webgl/WebGLRenderingContextBase.cpp b/Source/modules/webgl/WebGLRenderingContextBase.cpp
index cad3a3dbf67478d1a0014cd6ce52133e2abef3f4..4e839ed31742c6b1fd349de5cd915bf3fe3e48a6 100644
--- a/Source/modules/webgl/WebGLRenderingContextBase.cpp
+++ b/Source/modules/webgl/WebGLRenderingContextBase.cpp
@@ -1824,7 +1824,7 @@ void WebGLRenderingContextBase::compressedTexSubImage2D(GLenum target, GLint lev
if (!tex)
return;
- if (format != tex->getInternalFormat(target, level)) {
+ if (!isWebGL2OrHigher() && format != tex->getInternalFormat(target, level)) {
Zhenyao Mo 2015/07/29 20:57:57 It might be OK for now, but we do need to validate
synthesizeGLError(GL_INVALID_OPERATION, "compressedTexSubImage2D", "format does not match texture format");
return;
}
« no previous file with comments | « no previous file | Source/modules/webgl/WebGLTexture.cpp » ('j') | Source/modules/webgl/WebGLTexture.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698