chrome/browser/extensions/component_loader.cc - Issue 1257633002: Componentize VersionInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/component_loader.cc

Issue 1257633002: Componentize VersionInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Convert version_info::Channel to a "class enum" Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/component_loader.cc

diff --git a/chrome/browser/extensions/component_loader.cc b/chrome/browser/extensions/component_loader.cc

index 666a2639c2b477c879198c0c5289aedb8b9a71da..e9fb7d1d6d492f36c4f85adcde7244c9f89f341b 100644

--- a/chrome/browser/extensions/component_loader.cc

+++ b/chrome/browser/extensions/component_loader.cc

@@ -395,7 +395,7 @@ void ComponentLoader::AddGoogleNowExtension() {

// Enable the feature on trybots and trunk builds.

bool enabled_via_trunk_build =

- chrome::VersionInfo::GetChannel() == chrome::VersionInfo::CHANNEL_UNKNOWN;

+ chrome::VersionInfo::GetChannel() == version_info::Channel::UNKNOWN;

bool is_authenticated =

SigninManagerFactory::GetForProfile(profile_)->IsAuthenticated();