chrome/browser/extensions/chrome_notification_observer.cc - Issue 1257633002: Componentize VersionInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/chrome_notification_observer.cc

Issue 1257633002: Componentize VersionInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Convert version_info::Channel to a "class enum" Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/chrome_notification_observer.cc

diff --git a/chrome/browser/extensions/chrome_notification_observer.cc b/chrome/browser/extensions/chrome_notification_observer.cc

index c8e6016350809013f0f49a33923be8baf46fd21d..5b53a0ef00bedb804f4fcdb710d79d98008463b6 100644

--- a/chrome/browser/extensions/chrome_notification_observer.cc

+++ b/chrome/browser/extensions/chrome_notification_observer.cc

@@ -24,7 +24,8 @@ void ChromeNotificationObserver::OnRendererProcessCreated(

content::RenderProcessHost* process) {

// Extensions need to know the channel for API restrictions. Send the channel

// to all renderers, as the non-extension renderers may have content scripts.

- process->Send(new ExtensionMsg_SetChannel(GetCurrentChannel()));

+ process->Send(

+ new ExtensionMsg_SetChannel(static_cast<int>(GetCurrentChannel())));

}

void ChromeNotificationObserver::Observe(int type,