chrome/browser/extensions/error_console/error_console.cc - Issue 1257633002: Componentize VersionInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/error_console/error_console.cc

Issue 1257633002: Componentize VersionInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Convert version_info::Channel to a "class enum" Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/error_console/error_console.cc

diff --git a/chrome/browser/extensions/error_console/error_console.cc b/chrome/browser/extensions/error_console/error_console.cc

index cf6cf0ca6da0b5bb44fe37c5d3fbc4351367639f..420eb637fd318824b9d66effe90124de863e2d21 100644

--- a/chrome/browser/extensions/error_console/error_console.cc

+++ b/chrome/browser/extensions/error_console/error_console.cc

@@ -172,7 +172,7 @@ void ErrorConsole::RemoveObserver(Observer* observer) {

bool ErrorConsole::IsEnabledForChromeExtensionsPage() const {

if (!profile_->GetPrefs()->GetBoolean(prefs::kExtensionsUIDeveloperMode))

return false; // Only enabled in developer mode.

- if (GetCurrentChannel() > chrome::VersionInfo::CHANNEL_DEV &&

+ if (GetCurrentChannel() > version_info::Channel::DEV &&

!FeatureSwitch::error_console()->IsEnabled())

return false; // Restricted to dev channel or opt-in.