Source/core/loader/EmptyClients.h - Issue 1257583003: Make WebMediaPlayerClient inheritance private in HTMLMediaElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/EmptyClients.h

Issue 1257583003: Make WebMediaPlayerClient inheritance private in HTMLMediaElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address nit Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/loader/EmptyClients.h

diff --git a/Source/core/loader/EmptyClients.h b/Source/core/loader/EmptyClients.h

index 5616889eec06d2cbd619a0ee9a4440119b3c0933..57aa2ece6c2667142355541bf79714a364d655ed 100644

--- a/Source/core/loader/EmptyClients.h

+++ b/Source/core/loader/EmptyClients.h

@@ -233,7 +233,7 @@ public:

PassRefPtrWillBeRawPtr<Widget> createPlugin(HTMLPlugInElement*, const KURL&, const Vector<String>&, const Vector<String>&, const String&, bool, DetachedPluginPolicy) override;

bool canCreatePluginWithoutRenderer(const String& mimeType) const override { return false; }

PassRefPtrWillBeRawPtr<Widget> createJavaAppletWidget(HTMLAppletElement*, const KURL&, const Vector<String>&, const Vector<String>&) override;

- PassOwnPtr<WebMediaPlayer> createWebMediaPlayer(HTMLMediaElement*, const WebURL&) override;

+ PassOwnPtr<WebMediaPlayer> createWebMediaPlayer(HTMLMediaElement&, const WebURL&, WebMediaPlayerClient*) override;

ObjectContentType objectContentType(const KURL&, const String&, bool) override { return ObjectContentType(); }

« no previous file with comments | « Source/core/html/HTMLMediaElement.cpp ('k') | Source/core/loader/EmptyClients.cpp » ('j') | no next file with comments »