Source/core/loader/EmptyClients.cpp - Issue 1257583003: Make WebMediaPlayerClient inheritance private in HTMLMediaElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/EmptyClients.cpp

Issue 1257583003: Make WebMediaPlayerClient inheritance private in HTMLMediaElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address nit Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/loader/EmptyClients.cpp

diff --git a/Source/core/loader/EmptyClients.cpp b/Source/core/loader/EmptyClients.cpp

index ec3880c629fe191d5f223dda58897b627025de9b..d4d78adfbd30843f03fd402cb5fb6a8687d5ec43 100644

--- a/Source/core/loader/EmptyClients.cpp

+++ b/Source/core/loader/EmptyClients.cpp

@@ -135,7 +135,7 @@ PassRefPtrWillBeRawPtr<Widget> EmptyFrameLoaderClient::createJavaAppletWidget(HT

return nullptr;

}

-PassOwnPtr<WebMediaPlayer> EmptyFrameLoaderClient::createWebMediaPlayer(HTMLMediaElement*, const WebURL&)

+PassOwnPtr<WebMediaPlayer> EmptyFrameLoaderClient::createWebMediaPlayer(HTMLMediaElement&, const WebURL&, WebMediaPlayerClient*)

{

return nullptr;

}

« no previous file with comments | « Source/core/loader/EmptyClients.h ('k') | Source/core/loader/FrameLoaderClient.h » ('j') | no next file with comments »