Source/core/html/HTMLMediaElement.cpp - Issue 1257583003: Make WebMediaPlayerClient inheritance private in HTMLMediaElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 1257583003: Make WebMediaPlayerClient inheritance private in HTMLMediaElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address nit Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLMediaElement.cpp

diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp

index 113e1f090f708afd3780da70318424087f9c44f1..266251b08c3bb84fd50e33a4355ac5a2b2185d86 100644

--- a/Source/core/html/HTMLMediaElement.cpp

+++ b/Source/core/html/HTMLMediaElement.cpp

@@ -1031,7 +1031,7 @@ void HTMLMediaElement::startPlayerLoad()

}

KURL kurl(ParsedURLString, requestURL);

- m_webMediaPlayer = frame->loader().client()->createWebMediaPlayer(this, kurl);

+ m_webMediaPlayer = frame->loader().client()->createWebMediaPlayer(*this, kurl, this);

if (!m_webMediaPlayer) {

mediaLoadingFailed(WebMediaPlayer::NetworkStateFormatError);

return;

« no previous file with comments | « Source/core/html/HTMLMediaElement.h ('k') | Source/core/loader/EmptyClients.h » ('j') | no next file with comments »