Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 1257393005: [Thread Safety] Replace WebString bound by cross-thread base::Bind() with base::string16 (Closed)

Created:
5 years, 4 months ago by hiroshige
Modified:
5 years, 4 months ago
Reviewers:
kinuko
CC:
chromium-reviews, tim+watch_chromium.org, jsbell+serviceworker_chromium.org, serviceworker-reviews, zea+watch_chromium.org, tzik, maxbogue+watch_chromium.org, jam, kinuko+serviceworker, nhiroki, pvalenzuela+watch_chromium.org, michaeln, plaree+watch_chromium.org, jkarlin+watch_chromium.org, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Thread Safety] Replace WebString bound by cross-thread base::Bind() with base::string16 Passing WebString across threads is not thread-safe. Committed: https://crrev.com/dbcc3b2ac5dcc247498eb271d10c35988a1e35a6 Cr-Commit-Position: refs/heads/master@{#341315}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M content/child/background_sync/background_sync_provider_thread_proxy.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M content/child/navigator_connect/service_port_provider.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/child/service_worker/web_service_worker_impl.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257393005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257393005/1
5 years, 4 months ago (2015-07-31 09:28:41 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/22957)
5 years, 4 months ago (2015-07-31 10:19:43 UTC) #4
hiroshige
5 years, 4 months ago (2015-07-31 10:27:54 UTC) #6
kinuko
lgtm thanks!
5 years, 4 months ago (2015-07-31 10:55:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257393005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257393005/1
5 years, 4 months ago (2015-07-31 11:00:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-31 11:43:21 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 11:44:06 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dbcc3b2ac5dcc247498eb271d10c35988a1e35a6
Cr-Commit-Position: refs/heads/master@{#341315}

Powered by Google App Engine
This is Rietveld 408576698