content/child/navigator_connect/service_port_provider.cc - Issue 1257393005: [Thread Safety] Replace WebString bound by cross-thread base::Bind() with base::string16

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/navigator_connect/service_port_provider.cc

Issue 1257393005: [Thread Safety] Replace WebString bound by cross-thread base::Bind() with base::string16 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/background_sync/background_sync_provider_thread_proxy.cc ('k') | content/child/service_worker/web_service_worker_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/navigator_connect/service_port_provider.cc

diff --git a/content/child/navigator_connect/service_port_provider.cc b/content/child/navigator_connect/service_port_provider.cc

index 3f63b5f90ef974319c42e7914ede3f9d769710c8..c66a748dc1877689f65a1691e80e4a3f90533b6d 100644

--- a/content/child/navigator_connect/service_port_provider.cc

+++ b/content/child/navigator_connect/service_port_provider.cc

@@ -71,7 +71,9 @@ void ServicePortProvider::postMessage(

&WebMessagePortChannelImpl::ExtractMessagePortIDsWithoutQueueing,

base::Passed(&channel_array)),

base::Bind(&ServicePortProvider::PostMessageToBrowser, this, port_id,

- message));

+ // We cast WebString to string16 before crossing threads.

+ // for thread-safety.

+ static_cast<base::string16>(message)));

}

void ServicePortProvider::closePort(blink::WebServicePortID port_id) {