Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 12571010: cc: Add a pixel test for background blur outsets. (Closed)

Created:
7 years, 9 months ago by danakj
Modified:
7 years, 8 months ago
Reviewers:
jamesr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, piman, backer
Visibility:
Public.

Description

cc: Add remaining pixel tests for background blur. This replicates the following layout tests with compositor pixel tests: platform/chromium/compositing/filters/background-filter-blur-outsets.html platform/chromium/compositing/filters/background-filter-blur-off-axis.html The first test verifies that pixels from outside the bounds of the layer with background blur are used to contribute to the background behind the blurred layer. The second test verifies that the blur layer's transform does not affect the rendering of the blurred content behind it. New test: LayerTreeHostFiltersPixelTest.BackgroundFilterBlurOutsets LayerTreeHostFiltersPixelTest.BackgroundFilterBlurOffAxis R=jamesr,enne BUG=191170 Depends on: https://codereview.chromium.org/12518026/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191494

Patch Set 1 #

Patch Set 2 : Add offaxis #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : New tries #

Patch Set 6 : rebaseafterthemove #

Patch Set 7 : Output which pixels differ #

Patch Set 8 : Disable blending when drawing background filters #

Patch Set 9 : FuzzyOnWindows #

Patch Set 10 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -14 lines) Patch
M cc/output/gl_renderer.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 2 3 4 5 6 7 8 2 chunks +19 lines, -8 lines 0 comments Download
M cc/test/layer_tree_pixel_test.h View 1 2 3 4 5 6 7 8 4 chunks +10 lines, -0 lines 0 comments Download
M cc/test/layer_tree_pixel_test.cc View 1 2 3 4 5 6 7 8 4 chunks +34 lines, -3 lines 0 comments Download
M cc/test/pixel_comparator.h View 1 2 3 4 5 6 7 8 2 chunks +6 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_filters.cc View 1 2 3 4 5 6 7 8 9 2 chunks +80 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
danakj
7 years, 9 months ago (2013-03-14 01:54:06 UTC) #1
danakj
Added the off-axis test as well.
7 years, 9 months ago (2013-03-14 03:22:34 UTC) #2
danakj
Here's the pixels for these: http://imgur.com/TUcoUNy http://imgur.com/w0MttNK
7 years, 9 months ago (2013-03-14 18:35:10 UTC) #3
jamesr
lgtm
7 years, 9 months ago (2013-03-14 20:40:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/12571010/9001
7 years, 9 months ago (2013-03-15 17:55:38 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 9 months ago (2013-03-15 18:19:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/12571010/29001
7 years, 9 months ago (2013-03-15 18:24:17 UTC) #7
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=56813
7 years, 9 months ago (2013-03-15 18:49:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/12571010/29001
7 years, 9 months ago (2013-03-15 18:50:58 UTC) #9
danakj
Committed patchset #4 manually as r188524 (presubmit successful).
7 years, 9 months ago (2013-03-16 00:31:47 UTC) #10
danakj
Argh, reverted this. The trybots apparently skipped cc_unittests for mac and win and we get ...
7 years, 9 months ago (2013-03-16 01:02:13 UTC) #11
danakj
Mac 10.6 & 10.7 release both fail BackgroundFilterBlurOutsets: http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.6%20Tests%20%281%29&number=37241 http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.7%20Tests%20%281%29&number=9557 Mac 10.6 & 10.7 debug ...
7 years, 9 months ago (2013-03-16 01:09:27 UTC) #12
danakj
And Win7 debug and Win7 release x64 behave identically, both fail BackgroundFilterBlurOffAxis on 4 pixels. ...
7 years, 9 months ago (2013-03-16 01:12:23 UTC) #13
danakj
Yay now everything passes except 4 pixels in the BlurOffAxis test on win/win_rel.
7 years, 9 months ago (2013-03-26 22:31:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/12571010/98001
7 years, 8 months ago (2013-03-29 21:12:27 UTC) #15
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=129334
7 years, 8 months ago (2013-03-30 02:59:57 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/12571010/98001
7 years, 8 months ago (2013-03-30 03:24:46 UTC) #17
commit-bot: I haz the power
7 years, 8 months ago (2013-03-30 06:44:51 UTC) #18
Message was sent while issue was closed.
Change committed as 191494

Powered by Google App Engine
This is Rietveld 408576698