Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3926)

Unified Diff: cc/test/pixel_comparator.h

Issue 12571010: cc: Add a pixel test for background blur outsets. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/layer_tree_pixel_test.cc ('k') | cc/trees/layer_tree_host_pixeltest_filters.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/pixel_comparator.h
diff --git a/cc/test/pixel_comparator.h b/cc/test/pixel_comparator.h
index 9c12c21e7100ab5fd8ce701dd71e4550be836adf..d51eff09eacb03543f8a40d87c62b2882a480bdd 100644
--- a/cc/test/pixel_comparator.h
+++ b/cc/test/pixel_comparator.h
@@ -13,17 +13,18 @@ namespace cc {
// Interface for pixel comparators.
class PixelComparator {
public:
+ virtual ~PixelComparator() {}
+
virtual bool Compare(const SkBitmap& actual_bmp,
const SkBitmap& expected_bmp) const = 0;
-
- protected:
- virtual ~PixelComparator() {}
};
// Exact pixel comparator. Counts the number of pixel with an error.
class ExactPixelComparator : public PixelComparator {
public:
explicit ExactPixelComparator(const bool discard_alpha);
+ virtual ~ExactPixelComparator() {}
+
// Returns true if the two bitmaps are identical. Otherwise, returns false
// and report the number of pixels with an error on LOG(ERROR). Differences
// in the alpha channel are ignored.
@@ -45,6 +46,8 @@ class FuzzyPixelComparator : public PixelComparator {
const float avg_abs_error_limit,
const int max_abs_error_limit,
const int small_error_threshold);
+ virtual ~FuzzyPixelComparator() {}
+
// Computes error metrics and returns true if the errors don't exceed the
// specified limits. Otherwise, returns false and reports the error metrics on
// LOG(ERROR). Differences in the alpha channel are ignored.
« no previous file with comments | « cc/test/layer_tree_pixel_test.cc ('k') | cc/trees/layer_tree_host_pixeltest_filters.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698