Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Issue 12566022: Merge 187018 (Closed)

Created:
7 years, 9 months ago by aurimas (slooooooooow)
Modified:
7 years, 9 months ago
CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman
Visibility:
Public.

Description

Merge 187018 > [android] Always close Autofill popup through controller. > > Make sure that if dismiss is called by phone rotation it requests the > controller to dismiss the view instead of dismissing itself. > > Dependent on https://chromiumcodereview.appspot.com/12556002 > > BUG=175454 > NOTRY=true > > Review URL: https://chromiumcodereview.appspot.com/12395028 TBR=aurimas@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187368

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -19 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java View 2 chunks +11 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupGlue.java View 5 chunks +9 lines, -10 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/test/AutofillTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/autofill/autofill_popup_view_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/autofill/autofill_popup_view_android.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
aurimas (slooooooooow)
7 years, 9 months ago (2013-03-11 20:34:35 UTC) #1
aurimas (slooooooooow)
7 years, 9 months ago (2013-03-11 20:35:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r187368.

Powered by Google App Engine
This is Rietveld 408576698