Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4760)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java

Issue 12566022: Merge 187018 (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1410/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupGlue.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java
===================================================================
--- chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java (revision 187366)
+++ chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java (working copy)
@@ -58,9 +58,9 @@
*/
public interface AutofillPopupDelegate {
/**
- * Confirms the dismissal of the java AutofillPopup object.
+ * Requests the controller to hide AutofillPopup.
*/
- public void dismissed();
+ public void requestHide();
/**
* Handles the selection of an Autofill suggestion from an AutofillPopup.
@@ -175,14 +175,21 @@
mAnchorView.setSize(mAnchorRect, getDesiredWidth(suggestions));
}
+
/**
- * Dismisses the popup and calls to mAutofillCallback.dismissed().
+ * Overrides the default dismiss behavior to request the controller to dismiss the view.
*/
@Override
public void dismiss() {
+ mAutofillCallback.requestHide();
+ }
+
+ /**
+ * Hides the popup and removes the anchor view from the ContainerView.
+ */
+ public void hide() {
super.dismiss();
mContainerViewDelegate.removeViewFromContainerView(mAnchorView);
- mAutofillCallback.dismissed();
}
/**
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupGlue.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698