Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupGlue.java

Issue 12566022: Merge 187018 (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1410/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupGlue.java
===================================================================
--- chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupGlue.java (revision 187366)
+++ chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupGlue.java (working copy)
@@ -30,8 +30,8 @@
}
@Override
- public void dismissed() {
- nativeDismissed(mNativeAutofillPopup);
+ public void requestHide() {
+ nativeRequestHide(mNativeAutofillPopup);
}
@Override
@@ -40,12 +40,11 @@
}
/**
- * Dismisses the Autofill Popup, removes its anchor from the ContainerView and calls back
- * to AutofillPopupDelegate.dismiss().
+ * Hides the Autofill Popup and removes its anchor from the ContainerView.
*/
@CalledByNative
- public void dismiss() {
- mAutofillPopup.dismiss();
+ private void hide() {
+ mAutofillPopup.hide();
}
/**
@@ -53,7 +52,7 @@
* @param suggestions Autofill suggestions to be displayed.
*/
@CalledByNative
- public void show(AutofillSuggestion[] suggestions) {
+ private void show(AutofillSuggestion[] suggestions) {
mAutofillPopup.show(suggestions);
}
@@ -65,7 +64,7 @@
* @param height The height of the anchor.
*/
@CalledByNative
- public void setAnchorRect(float x, float y, float width, float height) {
+ private void setAnchorRect(float x, float y, float width, float height) {
mAutofillPopup.setAnchorRect(x, y, width, height);
}
@@ -77,12 +76,12 @@
* @return The AutofillSuggestion object with the specified data.
*/
@CalledByNative
- public static AutofillSuggestion createAutofillSuggestion(String name, String label,
+ private static AutofillSuggestion createAutofillSuggestion(String name, String label,
int uniqueId) {
return new AutofillSuggestion(name, label, uniqueId);
}
- private native void nativeDismissed(int nativeAutofillPopupViewAndroid);
+ private native void nativeRequestHide(int nativeAutofillPopupViewAndroid);
private native void nativeSuggestionSelected(int nativeAutofillPopupViewAndroid,
int listIndex);

Powered by Google App Engine
This is Rietveld 408576698