Issue 1256353004: Fix elliptical rrect clip shaders for large radii on devices with mediump

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1256353004: Fix elliptical rrect clip shaders for large radii on devices with mediump (Closed)

Created:
5 years, 4 months ago by bsalomon

Modified:
5 years, 4 months ago

Reviewers:
jvanverth1

CC:
review_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Fix elliptical rrect clip shaders for large radii on devices with mediump BUG=chromium:426217 Committed: https://skia.googlesource.com/skia/+/c41f4d60559b0891353f8028d521b52e7a36d5da

Patch Set 1 #

Patch Set 2 : Add GM #

Patch Set 3 : cleanup #

Patch Set 4 : more #

Patch Set 5 : more #

Patch Set 6 : rename file #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -3 lines)			Patch
A	gm/bigrrectaaeffect.cpp	View	1 2 3 4 5	1 chunk	+132 lines, -0 lines	0 comments	Download
M	src/gpu/effects/GrOvalEffect.cpp	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/gpu/effects/GrRRectEffect.cpp	View	1 2 3 4	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256353004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256353004/100001

5 years, 4 months ago (2015-08-03 21:15:22 UTC) #5

commit-bot: I haz the power

5 years, 4 months ago (2015-08-03 21:23:07 UTC) #6

Message was sent while issue was closed.

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/c41f4d60559b0891353f8028d521b52e7a36d5da

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages