build/config/BUILD.gn - Issue 1256223003: Revert "Add precompiled headers to GN build for large targets."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/BUILD.gn

Issue 1256223003: Revert "Add precompiled headers to GN build for large targets." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/BUILD.gn

diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn

index 618de26419d9027f231bebb5819dfcfdf5e2992e..56a86e5932783d772e57bf1885f42cbe3ce961c0 100644

--- a/build/config/BUILD.gn

+++ b/build/config/BUILD.gn

@@ -418,7 +418,9 @@ config("default_libs") {

# Recommend precompiled headers for targets with more than 50 .cc files.

config("precompiled_headers") {

- if (is_win) {

+ # TODO(brettw) enable this when GN support in the binary has been rolled.

+ #if (is_win) {

+ if (false) {

# This is a string rather than a file GN knows about. It has to match

# exactly what's in the /FI flag below, and what might appear in the source

# code in quotes for an #include directive.

« no previous file with comments | « base/test/BUILD.gn ('k') | build/config/compiler/BUILD.gn » ('j') | no next file with comments »