Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2402)

Unified Diff: Source/modules/serviceworkers/ExtendableEvent.h

Issue 1256133002: Service Worker: Correct Web IDL of ExtendableEvent.waitUntil method. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rename method params. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/ExtendableEvent.h
diff --git a/Source/modules/serviceworkers/ExtendableEvent.h b/Source/modules/serviceworkers/ExtendableEvent.h
index 585bc85111c35225324508c5775778f413fcca3e..21781095184201dd2a564260e87e4a480edbfebe 100644
--- a/Source/modules/serviceworkers/ExtendableEvent.h
+++ b/Source/modules/serviceworkers/ExtendableEvent.h
@@ -49,7 +49,7 @@ public:
~ExtendableEvent() override;
- void waitUntil(ScriptState*, const ScriptValue&, ExceptionState&);
+ void waitUntil(ScriptState*, ScriptPromise&, ExceptionState&);
yhirano 2015/07/27 12:21:24 Can you use |ScriptPromise| instead of |ScriptProm
jungkees 2015/07/27 12:37:49 Sure, but could you explain why? Both scriptPromis
yhirano 2015/07/27 12:45:32 ScriptPromise is a value and copying it is not exp
jungkees 2015/07/27 14:23:33 Agreed. Thanks for the explanation!
const AtomicString& interfaceName() const override;
DECLARE_VIRTUAL_TRACE();
« no previous file with comments | « no previous file | Source/modules/serviceworkers/ExtendableEvent.cpp » ('j') | Source/modules/serviceworkers/WaitUntilObserver.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698